Replace unmaintained android-properties crate with ndk API

I was surprised to find [the `android-properties` crate] with almost 8
*million* downloads; this crate hasn't been updated for almost 5 years
and the repository is a public archive.

Turns out the only published user of this crate is `android-activity`,
so all those downloads are pulled in from folks using this crate (mainly
through `winit`) to build Android apps.

Instead of using an unmaintained, archived crate, use the properties
wrapper and typed API-level wrappers provided in in an upcoming `ndk`
crate release instead:
- rust-mobile/ndk#495
- rust-mobile/ndk#479

[the `android-properties` crate]: https://crates.io/crates/android-properties

Author: MarijnS95

Cargo.toml

@@ -3,3 +3,7 @@ resolver = "2"
 members = ["android-activity"]
 
 exclude = ["examples"]
+
+[patch.crates-io]
+# https://github.com/rust-mobile/ndk/pull/495
+ndk = { git = "https://github.com/rust-mobile/ndk", rev = "9c63222" }

android-activity/Cargo.toml

@@ -42,7 +42,6 @@ jni = "0.21"
 ndk-sys = "0.6.0"
 ndk = { version = "0.9.0", default-features = false }
 ndk-context = "0.1.1"
-android-properties = "0.2"
 num_enum = "0.7"
 bitflags = "2.0"
 libc = "0.2.139"

android-activity/src/lib.rs

@@ -855,15 +855,14 @@ impl AndroidApp {
 
     /// The user-visible SDK version of the framework
     ///
-    /// Also referred to as [`Build.VERSION_CODES`](https://developer.android.com/reference/android/os/Build.VERSION_CODES)
+    /// The same value as [`Build.VERSION.SDK_INT`], containing a value from [`Build.VERSION_CODES`].
+    ///
+    /// [`Build.VERSION.SDK_INT`]: https://developer.android.com/reference/android/os/Build.VERSION#SDK_INT
+    /// [`Build.VERSION_CODES`]: https://developer.android.com/reference/android/os/Build.VERSION_CODES
     pub fn sdk_version() -> i32 {
-        let mut prop = android_properties::getprop("ro.build.version.sdk");
-        if let Some(val) = prop.value() {
-            val.parse::<i32>()
-                .expect("Failed to parse ro.build.version.sdk property")
-        } else {
-            panic!("Couldn't read ro.build.version.sdk system property");
-        }
+        // TODO: Replace with ndk::api_level::device_api_level() from https://github.com/rust-mobile/ndk/pull/479?
+        ndk::system_properties::get::<i32>(c"ro.build.version.sdk")
+            .expect("Failed to get or parse `ro.build.version.sdk` property")
     }
 
     /// Path to this application's internal data directory