Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default features in dependencies, especially jni #167

Open
Evrey opened this issue Sep 6, 2024 · 1 comment
Open

Disable default features in dependencies, especially jni #167

Evrey opened this issue Sep 6, 2024 · 1 comment

Comments

@Evrey
Copy link

Evrey commented Sep 6, 2024

JNI heavily lags behind with transitive dependency updates. With default features on it pulls in useless dependencies like windows-sys, resulting in multiple pulled depedency versions. That in turn needlessly lengthens package download and build times, which in turn hurts CI.

@MarijnS95
Copy link
Member

We've tried upgrading in #126, but there has not yet been a matching jni 0.22 release for jni-sys 0.4.

Feel free to PR changes that affect default feature flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants