Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set NLM_F_APPEND flag when adding bridge fdb neighbors #60

Open
mepholic opened this issue Apr 6, 2024 · 1 comment
Open

Comments

@mepholic
Copy link

mepholic commented Apr 6, 2024

I need the ability to set NLM_F_APPEND to append neighbors to the bridge fdb table. Appending to the bridge FDB table is required to add multiple L3 flood destinations to a vxlan interface. I'm currently using the add_bridge API. Upon inspecting the code in that file, I see that you can call replace, which causes the execute method to change NLM_F_EXCL to NLM_F_REPLACE in the final netlink request message.

I was about to open a PR to add append functionality when I saw #52, which is doing the same work, but for ip route instead of ip neigh/bridge fdb. I see this issue is waiting for #57 to be merged as well, and seeing as there is recent activity on this issue, I'm going to wait until this is merged before working on the feature that I need.

I'm also wondering at this point if NLM_F_APPEND is even valid for ip neigh entries, and if it makes sense for it to be combined with bridge fdb. In the networking world, the ARP/NDP tables (ip neigh) are related, but distinct from a switches forwarding table (bridge fdb)

@mepholic
Copy link
Author

mepholic commented Apr 6, 2024

So I just actually looked at the implementation in #57 and see that it is only adding a RouteMessageBuilder, and there is no equivalent Message Builder implementation for neighbors. Should there be?

I guess I won't be waiting for #57 to be merged after all. For now, I'm just going to do the simplest possible fix for the neighbour implementation, which is adding an append method to add.rs. If anyone has any thoughts, please feel free to share 😄

mepholic added a commit to mepholic/rtnetlink that referenced this issue Apr 9, 2024
… drivers

This is my attempt at fixing issue rust-netlink#60 on the Github project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant