-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Description
What would you think about simplifying the expression tree by
- Removing
SubExpr(and replacing it withAdd(Mul(-1, expr)) - Replacing
AddExpr(left, right)byAddExpr(Vec<expr>), to avoid creating deep trees (that cause Simplify overflows the stack #37)
This is not perfect, but should be easy to implement as a workaround for now. Would you accept such a PR ?
A more ambitious refactor that we can keep for later is to implement the expression as a simple HashMap<Variable, Coefficient>.
dlaehnemann
Metadata
Metadata
Assignees
Labels
No labels