Add borderless fullscreen mode for orbital (#4343)

Author: jackpot51

winit-core/src/window.rs

@@ -996,7 +996,8 @@ pub trait Window: AsAny + Send + Sync + fmt::Debug {
     ///   separate spaces are not preferred.
     ///
     ///   The dock and the menu bar are disabled in exclusive fullscreen mode.
-    /// - **Wayland:** Does not support exclusive fullscreen mode and will no-op a request.
+    /// - **Orbital / Wayland:** Does not support exclusive fullscreen mode and will no-op a
+    ///   request.
     /// - **Windows:** Screen saver is disabled in fullscreen mode.
     /// - **Web:** Passing a [`MonitorHandle`] or [`VideoMode`] that was not created with detailed
     ///   monitor permissions or calling without a [transient activation] does nothing.
@@ -1009,9 +1010,9 @@ pub trait Window: AsAny + Send + Sync + fmt::Debug {
     ///
     /// ## Platform-specific
     ///
-    /// - **Android / Orbital:** Will always return `None`.
+    /// - **Android:** Will always return `None`.
+    /// - **Orbital / Web:** Can only return `None` or `Borderless(None)`.
     /// - **Wayland:** Can return `Borderless(None)` when there are no monitors.
-    /// - **Web:** Can only return `None` or `Borderless(None)`.
     fn fullscreen(&self) -> Option<Fullscreen>;
 
     /// Turn window decorations on or off.

winit-orbital/src/window.rs

@@ -19,6 +19,7 @@ const ORBITAL_FLAG_FRONT: char = 'f';
 const ORBITAL_FLAG_HIDDEN: char = 'h';
 const ORBITAL_FLAG_BORDERLESS: char = 'l';
 const ORBITAL_FLAG_MAXIMIZED: char = 'm';
+const ORBITAL_FLAG_FULLSCREEN: char = 'M';
 const ORBITAL_FLAG_RESIZABLE: char = 'r';
 const ORBITAL_FLAG_TRANSPARENT: char = 't';
 
@@ -55,16 +56,17 @@ impl Window {
         // Async by default.
         let mut flag_str = ORBITAL_FLAG_ASYNC.to_string();
 
-        if attrs.maximized {
+        // Fullscreen takes precedence over maximize
+        if let Some(Fullscreen::Borderless(_)) = attrs.fullscreen {
+            flag_str.push(ORBITAL_FLAG_FULLSCREEN);
+        } else if attrs.maximized {
             flag_str.push(ORBITAL_FLAG_MAXIMIZED);
         }
 
         if attrs.resizable {
             flag_str.push(ORBITAL_FLAG_RESIZABLE);
         }
 
-        // TODO: fullscreen
-
         if attrs.transparent {
             flag_str.push(ORBITAL_FLAG_TRANSPARENT);
         }
@@ -323,10 +325,28 @@ impl CoreWindow for Window {
         self.get_flag(ORBITAL_FLAG_MAXIMIZED).unwrap_or(false)
     }
 
-    fn set_fullscreen(&self, _monitor: Option<Fullscreen>) {}
+    fn set_fullscreen(&self, fullscreen: Option<Fullscreen>) {
+        match fullscreen {
+            Some(Fullscreen::Exclusive(..)) => {
+                // TODO: exclusive fullscreen not supported on orbital
+            },
+            Some(Fullscreen::Borderless(_monitor)) => {
+                // TODO: monitor selection not supported on orbital
+                let _ = self.set_flag(ORBITAL_FLAG_FULLSCREEN, true);
+            },
+            None => {
+                let _ = self.set_flag(ORBITAL_FLAG_FULLSCREEN, false);
+            },
+        }
+    }
 
     fn fullscreen(&self) -> Option<Fullscreen> {
-        None
+        if self.get_flag(ORBITAL_FLAG_FULLSCREEN).unwrap_or(false) {
+            // TODO: monitor selection not supported on orbital
+            Some(Fullscreen::Borderless(None))
+        } else {
+            None
+        }
     }
 
     #[inline]

winit/src/changelog/unreleased.md

@@ -250,6 +250,7 @@ changelog entry.
 ### Fixed
 
 - On Orbital, `MonitorHandle::name()` now returns `None` instead of a dummy name.
+- On Orbital, implement `fullscreen`.
 - On iOS, fixed `SurfaceResized` and `Window::surface_size` not reporting the size of the actual surface.
 - On macOS, fixed the scancode conversion for audio volume keys.
 - On macOS, fixed the scancode conversion for `IntlBackslash`.