Skip to content

Use normal cfg values in examples #3539

@madsmtm

Description

@madsmtm

We started using cfg_aliases! in #2586, which I guess makes sense from a maintenance perspective (though I'll admit, I'm somewhat against it because it feels like an unnecessary dependency and adds build time).

However, its usage has crept into our examples, which I believe to be a bad idea, as the user will not be having those cfgs, meaning that they cannot directly copy our example code.

So I propose using the normal target_os = "macos"/feature = "x11" values in there.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C - needs discussionDirection must be ironed outS - docsAwareness, docs, examples, etc.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions