fix: assign commits to correct release

The algorithm to determine if a commit belongs to a specific release is
incorrectly assigning commits to the wrong releases for any release
except the first one.

It iterates over all commits with an enumerator attached, then skip any
commits belonging to previous releases, then skipping the commits
belonging to the current release, and finally uses the new enumerator
value as the count for the number of commits belonging to the release.

This is incorrect, as the enumerator shouldn't start counting until
after skipping the commits not belonging to the current release.

This is fixed by simplifying the iterator logic to count the relevant
commits.

Author: JeanMertz

src/changelog/changeset.rs

@@ -57,27 +57,25 @@ impl<'a> ChangeSet<'a> {
         }
 
         let idx = match tag {
-            None => Some(commits.len().checked_sub(1).unwrap_or_default()),
-            Some(tag) => commits
-                .iter()
-                .enumerate()
-                .skip(offset)
-                .skip_while(|(_, c)| c.id != tag.commit.id)
-                .map(|(idx, _)| idx)
-                .next(),
+            None => commits.iter().skip(offset).count(),
+            Some(tag) => {
+                commits
+                    .iter()
+                    .skip(offset)
+                    .take_while(|c| c.id != tag.commit.id)
+                    .count()
+                    + 1
+            }
         };
 
-        let changes = match idx {
-            None => return Ok(offset),
-            Some(idx) => commits
-                .iter()
-                .skip(offset)
-                .take(idx)
-                .filter_map(|commit| Change::new(&commit).ok())
-                .collect::<Vec<_>>(),
-        };
+        let changes = commits
+            .iter()
+            .skip(offset)
+            .take(idx)
+            .filter_map(|commit| Change::new(&commit).ok())
+            .collect::<Vec<_>>();
 
-        offset += idx.unwrap_or_default();
+        offset += idx;
 
         self.changes.append(
             &mut changes