Add advisory for unsound problem in scanner-rust#2000
Closed
safe4u wants to merge 1 commit intorustsec:mainfrom
Closed
Add advisory for unsound problem in scanner-rust#2000safe4u wants to merge 1 commit intorustsec:mainfrom
scanner-rust#2000safe4u wants to merge 1 commit intorustsec:mainfrom
Conversation
kornelski
approved these changes
Dec 4, 2024
Contributor
|
I see that this report is disputed by the crate author, and I didn't manage to reproduce any problem when I wrote a small fuzzer for the crate. Maybe this is a false positive? |
Contributor
Author
|
After further code review by the crate maintainer, the originally reported issue is considered a false positive. Based on this clarification, we are closing this PR. Thank you for the review and discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScannerU8SliceAsciicreates and parses non-utf8 str, which is unsound and might lead to undefined behaviors.The details are described in magiclen/scanner-rust#2.