Open
Conversation
Author
|
Hmm. Seems like depending on the specific build used, I guess this is now a situation that calls for regex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was wondering why
wasm-packis insisting on pulling and buildingcargo-generatedespite there already being one at/usr/bin/cargo-generate. I'm on EndeavourOS too so it is the newest version0.18.4.Turns out, the version check logic no longer works for the newest
cargo-generate. Right nowcargo-generate --versionprintscargo generate 0.18.4, which means the current logic is actually evaluating"generate" == "0.18.4". The same problem also exists forwasm-opt. This patch fixes this, along with adding a few helpful debug prints.You can test before and after using
RUST_LOG=debug cargo run -- new --mode no-install version-test.