Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to make Prompts not block on timeout #126

Open
rvesse opened this issue Aug 15, 2022 · 0 comments
Open

Find a way to make Prompts not block on timeout #126

rvesse opened this issue Aug 15, 2022 · 0 comments

Comments

@rvesse
Copy link
Owner

rvesse commented Aug 15, 2022

Originally noted in reviewing #125

When timeouts are used for prompts the read from the prompt provider happens on a background thread and is a blocking read. If the timeout is hit the thread doing that read is cancelled but may still be stuck in that blocking read and never actually terminate.

This means if there are subsequent prompts they may not read anything because they are queued up behind the blocked read. This necessitates users having to hit the return key extra times, or enter their response multiple times.

Might be useful to make this interruptible, or otherwise track unfinished reads and prevent subsequent prompts on the provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant