Skip to content

Commit 2ceaf6a

Browse files
committed
Comment cleanup and updates
1 parent 264ee7c commit 2ceaf6a

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
name: Test
1515
on:
1616
push:
17-
branches: [master, v-2-1-0]
17+
branches: [master]
1818
jobs:
1919
flutter_test:
2020
runs-on: ubuntu-latest

lib/src/flex_color_scheme.dart

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2179,26 +2179,32 @@ class FlexColorScheme with Diagnosticable {
21792179
? const IconThemeData(color: Colors.white)
21802180
: const IconThemeData(color: Colors.black87),
21812181
elevation: appBarElevation,
2182-
// TODO: Trying to use AppBarTheme overlay style here to style sysnav.
21832182
systemOverlayStyle: SystemUiOverlayStyle(
21842183
// AppBar overlay style.
21852184
statusBarColor: transparentStatusBar
21862185
? Colors.transparent
2186+
// This is the actual scrim color used by Android by default,
2187+
// here we just re-apply if false or if it had been removed
2188+
// earlier, using `null` does not restore we need the actual used
2189+
// scrim by Android ro restore if it has been removed earlier.
21872190
: const Color(0x40000000),
21882191
statusBarBrightness: _appBarBrightness,
21892192
statusBarIconBrightness: _appBarBrightness == Brightness.dark
21902193
? Brightness.light
21912194
: Brightness.dark,
2192-
// System navbar overlay - The one used by default AppBar in SDK:
2195+
2196+
// The systemNavigationBarColor used by default AppBar in SDK:
21932197
systemNavigationBarColor: const Color(0xFF000000),
21942198
// Would be nice if this worked instead of above, but it does not:
21952199
// systemNavigationBarColor: _isDark ? Colors.black : Colors.white;,
2196-
// System navbar overlay - The one used by default AppBar in SDK:
2200+
2201+
// The systemNavigationBarIconBrightness used by the AppBar in SDK:
21972202
systemNavigationBarIconBrightness: Brightness.dark,
21982203
// Would be nice if this worked instead of above, but it does not:
21992204
// systemNavigationBarIconBrightness:
22002205
// _isDark ? Brightness.light : Brightness.dark,
2201-
// System navbar overlay - The one used by default AppBar in SDK:
2206+
2207+
// The systemNavigationBarDividerColor used by default AppBar in SDK:
22022208
// ignore: avoid_redundant_argument_values
22032209
systemNavigationBarDividerColor: null,
22042210
),

0 commit comments

Comments
 (0)