Skip to content

Commit 4e5d44f

Browse files
rydmikerydmike
committed
Playground: Update known issues info expands with latest status of known issues
1 parent 68133a1 commit 4e5d44f

File tree

12 files changed

+137
-89
lines changed

12 files changed

+137
-89
lines changed

‎example/lib/example5_themes_playground/widgets/pages/model/theme_topic.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -629,9 +629,9 @@ const List<Topic> themeTopics = <Topic>[
629629
heading: 'Android System Navigation Bar',
630630
buttonLabel: 'Android\nSystem Nav',
631631
icon: Icons.android_outlined,
632-
info: 'The system navigation bar in Android is in newer versions '
632+
info: 'The system navigation bar in Android is in current Android versions '
633633
'a swipe bar at the bottom of the screen used for swipe '
634-
'gestures. In older versions it is made up of the 3 system '
634+
'gestures. In older Android versions it is made up of the 3 system '
635635
'navigation buttons. The system navigation area can be styled '
636636
'in Flutter, but not via themes.\n'
637637
'\n'

‎example/lib/example5_themes_playground/widgets/panels/app_bar/app_bar_panel.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ class AppBarPanel extends StatelessWidget {
597597
),
598598
TextSpan(
599599
style: spanTextStyle,
600-
text: '. The issue is still in effect in Flutter 3.24, '
600+
text: '. The issue is still in effect in Flutter 3.35.1. '
601601
'FCS includes the fix mentioned in the '
602602
'issue to make the color change animated.\n',
603603
),

‎example/lib/example5_themes_playground/widgets/panels/bottom_sheet/bottom_sheet_panel.dart‎

Lines changed: 60 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import 'package:flutter/material.dart';
22

33
import '../../../../shared/controllers/theme_controller.dart';
4-
import '../../../../shared/utils/link_text_span.dart';
54
import '../../../../shared/widgets/universal/list_tile_reveal.dart';
65
import '../../../../shared/widgets/universal/showcase_material.dart';
76
import '../../../../shared/widgets/universal/slider_list_tile_reveal.dart';
@@ -14,28 +13,28 @@ class BottomSheetPanel extends StatelessWidget {
1413

1514
final ThemeController controller;
1615

17-
static final Uri _fcsIssue270 = Uri(
18-
scheme: 'https',
19-
host: 'github.com',
20-
path: 'rydmike/flex_color_scheme/issues/270',
21-
);
22-
23-
static final Uri _fcsFlutterIssue160963 = Uri(
24-
scheme: 'https',
25-
host: 'github.com',
26-
path: 'flutter/flutter/issues/160963',
27-
);
16+
// static final Uri _fcsIssue270 = Uri(
17+
// scheme: 'https',
18+
// host: 'github.com',
19+
// path: 'rydmike/flex_color_scheme/issues/270',
20+
// );
21+
//
22+
// static final Uri _fcsFlutterIssue160963 = Uri(
23+
// scheme: 'https',
24+
// host: 'github.com',
25+
// path: 'flutter/flutter/issues/160963',
26+
// );
2827

2928
@override
3029
Widget build(BuildContext context) {
3130
final ThemeData theme = Theme.of(context);
3231
final bool useMaterial3 = theme.useMaterial3;
33-
final TextStyle spanTextStyle = theme.textTheme.bodySmall!
34-
.copyWith(color: theme.colorScheme.onSurfaceVariant);
35-
final TextStyle linkStyle = theme.textTheme.bodySmall!.copyWith(
36-
color: theme.colorScheme.primary,
37-
fontWeight: FontWeight.bold,
38-
);
32+
// final TextStyle spanTextStyle = theme.textTheme.bodySmall!
33+
// .copyWith(color: theme.colorScheme.onSurfaceVariant);
34+
// final TextStyle linkStyle = theme.textTheme.bodySmall!.copyWith(
35+
// color: theme.colorScheme.primary,
36+
// fontWeight: FontWeight.bold,
37+
// );
3938

4039
// The most common logic for enabling Playground controls.
4140
final bool enableControl =
@@ -144,49 +143,49 @@ class BottomSheetPanel extends StatelessWidget {
144143
value: controller.bottomSheetModalSchemeColor,
145144
onChanged: controller.setBottomSheetModalSchemeColor,
146145
),
147-
const Divider(),
148-
ListTileReveal(
149-
dense: true,
150-
title: const Text('Known issues'),
151-
subtitleReveal: RichText(
152-
text: TextSpan(
153-
children: <TextSpan>[
154-
TextSpan(
155-
style: spanTextStyle,
156-
text: 'Using a BackdropFilter with a BottomSheet does not '
157-
'work if any other content clip behavior than Clip.none '
158-
'is used. This is a known issue in Flutter, see '
159-
'Flutter SDK ',
160-
),
161-
LinkTextSpan(
162-
style: linkStyle,
163-
uri: _fcsFlutterIssue160963,
164-
text: 'issue #160963',
165-
),
166-
// _fcsChipUmbrellaIssue115364
167-
TextSpan(
168-
style: spanTextStyle,
169-
text: '.\n\n'
170-
'The issues is also reported in the FlexColorScheme '
171-
'issue tracker, see issue ',
172-
),
173-
LinkTextSpan(
174-
style: linkStyle,
175-
uri: _fcsIssue270,
176-
text: 'issue #270',
177-
),
178-
TextSpan(
179-
style: spanTextStyle,
180-
text: '. It contains a work around example that can be used '
181-
'to change the clip behavior to Clip.none, if you need '
182-
'to use a BackdropFilter with a BottomSheet, with FCS '
183-
'versions prior to 8.1.0, when the property value '
184-
'defaulted to Clip.antiAlias and could not be changed.\n',
185-
),
186-
],
187-
),
188-
),
189-
),
146+
// const Divider(),
147+
// ListTileReveal(
148+
// dense: true,
149+
// title: const Text('Known issues'),
150+
// subtitleReveal: RichText(
151+
// text: TextSpan(
152+
// children: <TextSpan>[
153+
// TextSpan(
154+
// style: spanTextStyle,
155+
// text: 'Using a BackdropFilter with a BottomSheet does not '
156+
// 'work if any other content clip behavior than Clip.none '
157+
// 'is used. This is a known issue in Flutter, see '
158+
// 'Flutter SDK ',
159+
// ),
160+
// LinkTextSpan(
161+
// style: linkStyle,
162+
// uri: _fcsFlutterIssue160963,
163+
// text: 'issue #160963',
164+
// ),
165+
// // _fcsChipUmbrellaIssue115364
166+
// TextSpan(
167+
// style: spanTextStyle,
168+
// text: '.\n\n'
169+
// 'The issues is also reported in the FlexColorScheme '
170+
// 'issue tracker, see issue ',
171+
// ),
172+
// LinkTextSpan(
173+
// style: linkStyle,
174+
// uri: _fcsIssue270,
175+
// text: 'issue #270',
176+
// ),
177+
// TextSpan(
178+
// style: spanTextStyle,
179+
// text: '. It contains a work around example that can be used '
180+
// 'to change the clip behavior to Clip.none, if you need '
181+
// 'to use a BackdropFilter with a BottomSheet, with FCS '
182+
// 'versions prior to 8.1.0, when the property value '
183+
// 'defaulted to Clip.antiAlias and could not be changed.\n',
184+
// ),
185+
// ],
186+
// ),
187+
// ),
188+
// ),
190189
],
191190
);
192191
}

‎example/lib/example5_themes_playground/widgets/panels/dialog/dialog_panel.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -640,8 +640,8 @@ class DialogPanel extends StatelessWidget {
640640
),
641641
TextSpan(
642642
style: spanTextStyle,
643-
text: '.\n The DatePicker should adopt the working prior '
644-
'art solution used by the TimePicker.',
643+
text: '. The DatePicker should prefer to adopt the working '
644+
'prior art solution used by the TimePicker.',
645645
),
646646
],
647647
),

‎example/lib/example5_themes_playground/widgets/panels/menus/menus_panel.dart‎

Lines changed: 44 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,18 @@ class MenusPanel extends StatelessWidget {
1515
const MenusPanel(this.controller, {super.key});
1616
final ThemeController controller;
1717

18+
static final Uri _menuSizeIssue170970 = Uri(
19+
scheme: 'https',
20+
host: 'github.com',
21+
path: 'flutter/flutter/issues/170970',
22+
);
23+
24+
static final Uri _menuSizeIssue169438PR = Uri(
25+
scheme: 'https',
26+
host: 'github.com',
27+
path: 'flutter/flutter/pull/169438',
28+
);
29+
1830
static final Uri _menuNoThemeOnFocusedIssue123736 = Uri(
1931
scheme: 'https',
2032
host: 'github.com',
@@ -353,9 +365,35 @@ class MenusPanel extends StatelessWidget {
353365
children: <TextSpan>[
354366
TextSpan(
355367
style: spanTextStyle,
356-
text: 'The selected and focused style of any item found in '
357-
'the DropdownMenu is not themed. This is a bug in '
358-
'Flutter SDK. For more information see ',
368+
text: 'The width of the DropdownMenu no longer by default '
369+
'matches the width of the dropdown input field. This is '
370+
'a regression bug in Flutter SDK that was introduced in '
371+
'version 3.32.0. For more information see ',
372+
),
373+
LinkTextSpan(
374+
style: linkStyle,
375+
uri: _menuSizeIssue170970,
376+
text: 'issue #170970',
377+
),
378+
TextSpan(
379+
style: spanTextStyle,
380+
text: '. This has been fixed in master, but has not yet '
381+
'landed in Flutter 3.35.1. See ',
382+
),
383+
LinkTextSpan(
384+
style: linkStyle,
385+
uri: _menuSizeIssue169438PR,
386+
text: 'PR #169438',
387+
),
388+
TextSpan(
389+
style: spanTextStyle,
390+
text: '. FlexColorScheme version 8.3.0 includes a built-in '
391+
'workaround for this issue that will be used until the '
392+
'FIX PR is merged into the stable channel.\n'
393+
'\n'
394+
'The selected and focused style of any item found in '
395+
'the DropdownMenu is not themed. This was a bug in '
396+
'Flutter SDK before 3.27. For more information see ',
359397
),
360398
LinkTextSpan(
361399
style: linkStyle,
@@ -364,8 +402,7 @@ class MenusPanel extends StatelessWidget {
364402
),
365403
TextSpan(
366404
style: spanTextStyle,
367-
text: '. This has been fixed in master, but has not yet '
368-
'landed in Flutter 3.24.\n'
405+
text: '. This has been fixed in Flutter 3.27 and later.\n'
369406
'\n'
370407
'There are three reported '
371408
'issues about the DropdownMenu not following the '
@@ -379,8 +416,8 @@ class MenusPanel extends StatelessWidget {
379416
),
380417
TextSpan(
381418
style: spanTextStyle,
382-
text: '. This FIX PR, that also links the issues, '
383-
'has landed in master, but not yet in Flutter 3.24.\n'
419+
text: '. The FIX PR, that also links the issues and the FIX '
420+
'landed in Flutter 3.27.\n'
384421
'\n'
385422
'Another issue was using leading icons on both menu '
386423
'input field and the items as show in the above example. '

‎example/lib/example5_themes_playground/widgets/panels/navigation_drawer/navigation_drawer_panel.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ class NavigationDrawerPanel extends StatelessWidget {
319319
),
320320
TextSpan(
321321
style: spanTextStyle,
322-
text: '. A few of them have been solved, but most '
322+
text: '. A few of them have been solved, but many '
323323
'are open and still impact latest Flutter release.\n',
324324
),
325325
],

‎example/lib/example5_themes_playground/widgets/panels/navigation_rail/navigation_rail_panel.dart‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class NavigationRailPanel extends StatelessWidget {
2222
path: 'rydmike/flex_color_scheme/issues/277',
2323
);
2424

25-
// TODO(rydmike): To be added when issue is created
25+
// TODO(rydmike): To be added when Flutter issue for the above is created
2626
// static final Uri _railIssueFlutter = Uri(
2727
// scheme: 'https',
2828
// host: 'github.com',
@@ -105,10 +105,10 @@ class NavigationRailPanel extends StatelessWidget {
105105
children: <TextSpan>[
106106
TextSpan(
107107
style: spanTextStyle,
108-
text: 'If you any other labType than none and show the '
108+
text: 'If you use any other labType than none and show the '
109109
'NavigationRail in extended state, Flutter SDK will '
110-
'throw. This is a Flutter SDK limitation, not '
111-
'FlexColorScheme related, see ',
110+
'throw an exception. This is a Flutter SDK limitation, '
111+
'not FlexColorScheme related, see ',
112112
),
113113
LinkTextSpan(
114114
style: linkStyle,

‎example/lib/example5_themes_playground/widgets/panels/search_bar/search_bar_panel.dart‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,11 +169,12 @@ class SearchBarPanel extends StatelessWidget {
169169
text: '. This issue has been fixed in Flutter 3.13.\n'
170170
'\n'
171171
'The SearchView suffers from the common Flutter lack '
172-
'of support f variant themes, thus if you set the '
172+
'of support for variant themes, thus if you set the '
173173
'shape to something else for the none full screen mode '
174174
'the full screen mode gets the same shape. You do not '
175-
'want or expect that, it should remain without a shape '
176-
'in full screen mode. See issue <report and add link>.',
175+
'want or expect that. It should remain without a shape '
176+
'in full screen mode. See issue <not yet reported '
177+
'or is it? Let me know if it is, or report it.>.',
177178
),
178179
],
179180
),

‎example/lib/example5_themes_playground/widgets/panels/segmented_buttons/segmented_buttons_panel.dart‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,8 @@ class SegmentedButtonsPanel extends StatelessWidget {
278278
),
279279
TextSpan(
280280
style: spanTextStyle,
281-
text: ', these issues are fixed in Flutter 3.10.\n\n'
281+
text: ', these issues are fixed in Flutter 3.10 and later.'
282+
'\n\n'
282283
'The minimum height or size cannot be set, see ',
283284
),
284285
LinkTextSpan(
@@ -297,10 +298,10 @@ class SegmentedButtonsPanel extends StatelessWidget {
297298
),
298299
TextSpan(
299300
style: spanTextStyle,
300-
text: '. The former issue is closed, but NOT fixed! '
301+
text: '. The former issue was fixed in Flutter 3.22. '
301302
'The PR that closed it only fixed the wrong spec '
302303
'default size, but did not make it customizable. The '
303-
'latter issue is still open and has no fix yet.',
304+
'latter issue is was fixed in Flutter 3.27.',
304305
),
305306
],
306307
),

‎example/lib/example5_themes_playground/widgets/panels/sliders/sliders_panel.dart‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,11 @@ class SlidersPanel extends StatelessWidget {
202202
'style as a better match with M3 than the rectangle in '
203203
'M3 mode as default.\n'
204204
'\n'
205+
'The Sliders theming in FlexColorScheme and the '
206+
'Playground do not yet support the revised and newer '
207+
'Material-3 designs. This will be added in a coming '
208+
'update.\n'
209+
'\n'
205210
'RangeSlider also behaves differently from Slider when '
206211
'looking at things like hover and focus responses. It '
207212
'also lacks any kind of keyboard usage support. '

0 commit comments

Comments
 (0)