Skip to content

Hold Pedal also affects note editing / playback #521

@ephemer

Description

@ephemer

First of all, please let me say congratulations and thank you for your fantastic project. It's very professional and a lot of fun to use!

Describe the bug

While editing a song with the pencil tool, we can hear the notes being selected – this is great. However, if we're at a part of the song where the hold pedal is pressed, the hold pedal also affects note input and editing, even when paused.

This behaviour was very confusing to me until I figured out what it was: other editors (e.g. Logic Pro) do not do this.

If the hold pedal is at its maximum value, the notes ring out forever (The first time I noticed this I heard a strange buzzing sound from my laptop 20-30mins after pressing the notes: it was the same notes still ringing out).

To Reproduce

  1. Create a new song
  2. Click Hold Pedal and add a high value (e.g. 127)
  3. Navigate to the part of the song where you activated the hold pedal
  4. Add or move some notes in the Piano Roll, including on the Keyboard itself -> the notes will ring out forever (at least, until you navigate to a part of the song with no hold pedal active)

Expected behavior

Hold Pedal should not affect the editor's synth "playback" while paused.

Desktop (please complete the following information):

  • OS: web
  • Browser: any

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions