-
Notifications
You must be signed in to change notification settings - Fork 48
Description
In Step 3 of the Exotic Standard Google Colab, the function make_inits_file
is called. This function is defined in EXOTIC/exotic/api/colab.py
That function calls another function, find
, where a set of default values for mObs is hardcoded:
mobs = {"FILTER": "V", "LATITUDE": "+37.04", "LONGITUD": "-110.73", "HEIGHT": 2606 }
"Pixel Binning": "1x1",
However, in EXOTIC/exotic.py
, there is a different set of mObs values:
# checks for MOBS data
if 'CREATOR' in header:
if 'MicroObservatory' in header['CREATOR'] and 'MOBS' not in exotic_infoDict['second_obs'].upper():
if exotic_infoDict['second_obs'].upper() != "":
exotic_infoDict['second_obs'] += ",MOBS"
else:
exotic_infoDict['second_obs'] = "MOBS"
exotic_infoDict['filter'] = "MObs CV"
exotic_infoDict['elev'] = 1268
exotic_infoDict['lat'] = 31.675467
exotic_infoDict['long'] = -110.951376
exotic_infoDict['pixel_bin'] = "2x2"
To summarize, there are two different sets of values being used for mObs:
Filter: MObs CV (which is translated to just CV in EXOTIC/exotic/api/filters.py) vs V
Elevation/Height: 1268 vs 2606
Latitude: 31.675467 vs 37.04
Longitude: -110.951376 vs -110.73
Binning: "2x2" vs "1x1"
I spoke with Frank S., and he confirmed that the correct values should be:
Filter: CV
Elevation/Height: 1268
Latitude: +31.675467
Longitude: -110.951376
Binning: "2x2"
Based on this, it looks like the values currently used in colab.py are incorrect, and should be updated to match the set in exotic.py.
@rzellem — would you like me to go ahead and create a PR for your review and consideration?