Fixed both issues below:
-The closing %5D = “]” should likely be removed.
-https://journals.sagepub.com/doi/abs/10.1177/1536867X19830877?journalCode=stja,
-Please write DOIs as doi:10.1177/1536867X19830877 in the Description field without the rest of the URL.
-Please apologize the quick re-submission. Version 0.5.1 fixes a bug introduced in version 0.5.
-Changes:
-boottest() now stops if fixest::feols() deletes non-NA values (e.g. singleton fixed effects deletion) and asks the user to delete such rows prior to estimation via feols() & boottest(). Currently, boottest()'s pre-processing cannot handle such deletions - this remains future work.fwildclusterboot with Stata’s boottest command (Roodman et al, 2019), Mammen weights are no longer enumerated in fwildclusterboot::boottest().boottest() no longer sets an internal seed (previously set.seed(1)) if no seed is provided as a function argument.dqrng package, which speeds up the creation of the bootstrap weights matrix. To set a “global” seed, one now has use the dqset.seed() function from the dqrng package, which is added as a dependency.Apparently, I did not fix the openBLAS error appropriately. The test tolerance level has again been reduced, from 1e-04 to 1e-02. The relative test difference found in the openBLAS tests is 0.003568575, so the test should now pass. If this does not fix the issue, I will remote all tests in test_type from CRAN.
-The error stated " test_type.R………………. 139 tests 1 fails test_type.R………………. 140 tests 2 fails test_type.R………………. 140 tests 2 fails test_type.R………………. 140 tests 2 fails test_type.R………………. 140 tests 2 fails test_type.R………………. 140 tests 2 fails test_type.R………………. 140 tests 2 fails test_type.R………………. 141 tests 2 fails test_type.R………………. 142 tests 2 fails test_type.R………………. 143 tests 2 fails test_type.R………………. 144 tests 2 fails test_type.R………………. 145 tests 2 fails test_type.R………………. 146 tests 2 fails test_type.R………………. 147 tests 2 fails test_type.R………………. 148 tests 2 fails test_type.R………………. 149 tests 2 fails test_type.R………………. 150 tests 2 fails test_type.R………………. 151 tests 2 fails test_type.R………………. 152 tests 2 fails test_type.R………………. 153 tests 2 fails test_type.R………………. 154 tests 2 fails test_type.R………………. 155 tests 2 fails test_type.R………………. 156 tests 2 fails test_type.R………………. 157 tests 2 fails test_type.R………………. 158 tests 2 fails test_type.R………………. 159 tests 2 fails test_type.R………………. 160 tests 2 fails 4.6s —– FAILED[data]: test_type.R<345–345> call| expect_equivalent(boot_fixest_c\(conf_int, boot_felm_c\)conf_int, call| –> tol = 1e-04) diff| Mean relative difference: 0.003568575 —– FAILED[data]: test_type.R<346–346> call| expect_equivalent(boot_felm_c\(conf_int, boot_lm\)conf_int, tol = 1e-04) diff| Mean relative difference: 0.00357477 Error: 2 out of 868 tests failed In addition: Warning messages: 1: There are only 1024 unique draws from the rademacher distribution for 10 clusters. Therefore, B = 1024 with full enumeration. Consider using webb weights instead. 2: Further, note that under full enumeration and with B = 1024 bootstrap draws, only 2^(#clusters - 1) = 512 distinct t-statistics and p-values can be computed. For a more thorough discussion, see Webb Reworking wild bootstrap based inference for clustered errors (2013). 3: There are only 1024 unique draws from the rademacher distribution for 10 clusters. Therefore, B = 1024 with full enumeration. Consider using webb weights instead. 4: Further, note that under full enumeration and with B = 1024 bootstrap draws, only 2^(#clusters - 1) = 512 distinct t-statistics and p-values can be computed. For a more thorough discussion, see Webb Reworking wild bootstrap based inference for clustered errors (2013). Execution halted "
The openBLAS error on CRAN has been fixed (point for in version 0.4 submission. Some tests for exact equality failed with relative difference e-05 on openBLAS. In consequence, all exact tests are set to reltol = 1e-04. This should fix all CRAN errors.
-boottest() now allows for univariate tests that involve multiple variables. E.g. one can now test hypothesis as ´var1 + var2 = c´ where c is a scalar. More details on the syntax can be found in the vignette. All methods of for objects of class boottest have been updated.boottest() now also supports “equal-tailed” p-values and one-sided hypotheses. For one-sided tests, confidence intervals are currently not supported.boot_algo2() function has slightly been modified. invert_p_val2() is superseded by invert_p_val().Please correct before 2021-08-08 to safely retain your package on CRAN.
-Packages in Suggests should be used conditionally: see ‘Writing R Extensions’. This needs to be corrected even if the missing package(s) become available."
-Solution: add if(requireNamespace(“pkg”)) for suggested packages in vignette, examples, tests
-I have checked package installation via github actions on windows, mac, ubuntu & ubuntu devel - installation fails on ubuntu devel because the “lfe” package cannot be installed.
-Further, the packages passes the checks via devtools::check_win_devel()
-** running tests for arch ‘i386’ … [296s] OK ** running tests for arch ‘x64’ … [239s] OK
-Please reduce the test timings by using
-Long-running tests now only run on developing versions (4-digit) - this submission is 3-digit (0.3.1)
-DONE
-DONE. Added return values to all functions OR functions are no longer exported.
-DONE. deleted fwildclusterboot::: call from examples
-Thanks, we see: + Found the following (possibly) invalid URLs: URL: https://www.tidyverse.org/lifecycle/#experimental (moved to https://lifecycle.r-lib.org/articles/stages.html) From: README.md Status: 200 Message: OK
-Please change http –> https, add trailing slashes, or follow moved content as appropriate.
-Moved URL https://www.tidyverse.org/lifecycle/#experimental to https://lifecycle.r-lib.org/articles/stages.html
-License components with restrictions and base license permitting such: GPL-3 + file LICENSE File ‘LICENSE’: YEAR: 2021 COPYRIGHT HOLDER: fwildclusterboot authors
-That LICENSE file is nonsense for the GPL-3. If you want GPL-3, then you do not need any LICENSE file.
-License file was deleted.
Unknown, possibly mis-spelled, fields in DESCRIPTION: ‘SourceCode’
-Source Code was change to URL.
Found the following (possibly) invalid URLs: URL: (https://academic.oup.com/ectj/article-abstract/21/2/114/5078969) From: inst/doc/fwildclusterboot.html Message: Invalid URI scheme
-Omite the parentheses. Parantheses were deleted.
URL: https://s3alfisc.github.io/fwildclusterboot (moved to https://s3alfisc.github.io/fwildclusterboot/) From: DESCRIPTION Status: 200 Message: OK
-Please change http –> https, add trailing slashes, or follow moved content as appropriate.
-Trail slashes were added for https://s3alfisc.github.io/fwildclusterboot/ and https://github.com/s3alfisc/fwildclusterboot/issues/
0 errors | 0 warnings | 1 note
-