Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement named parameters in mapping types #15

Open
allwin199 opened this issue Jul 17, 2023 · 1 comment
Open

Implement named parameters in mapping types #15

allwin199 opened this issue Jul 17, 2023 · 1 comment
Labels
effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@allwin199
Copy link

In RecipientHooks.sol

mapping(address => uint256) internal _balances;

It can be changed to

mapping(address caller => uint256 amount) internal _balances;

for better readability.
@allwin199
Copy link
Author

I can change this, if necessary.

@PaulRBerg PaulRBerg added work: obvious type: feature New feature or request. effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. and removed work: obvious labels Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PaulRBerg @allwin199