Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Solidity v0.8.11 and below #10

Open
PaulRBerg opened this issue May 27, 2024 · 0 comments
Open

Support Solidity v0.8.11 and below #10

PaulRBerg opened this issue May 27, 2024 · 0 comments
Labels
effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Member

PaulRBerg commented May 27, 2024 •
edited
Loading

We're using abi.encodeCall, which was introduced in Solidity v0.8.11.

We have to use v0.8.12 because v0.8.11 had a bug and ContractName.function syntax wasn't supported.

Anyway, the fix is to use the lower-level abi.encodeWithSelector.

See:
@PaulRBerg PaulRBerg added effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels May 27, 2024
@PaulRBerg PaulRBerg changed the title Support Solidity v0.8.10 and below Support Solidity v0.8.11 and below May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulRBerg