remove some commented code

Author: fchapoton

src/sage/rings/number_field/class_group.py

@@ -267,23 +267,21 @@ def __mul__(self, other):
                        check=False)
 
     def lcm(self, other) -> "Modulus":
+        """
+        missing documentation
+        """
         inf = tuple(set(self.infinite_part()).union(other.infinite_part()))
-        # Pe_out = []
         self_fact_P, self_fact_e = zip(*self.finite_part().factor())
         self_fact_P = list(self_fact_P)
         self_fact_e = list(self_fact_e)
-        # self_facts = self.finite_part().factor()
-        # of = other.finite_part()
         other_facts = other.finite_part().factor()
         mf = self._number_field.ideal_monoid().one()
         for P, e in other_facts:
             try:
                 i = self_fact_P.index(P)
             except ValueError:
-                # Pe_out.append([P, e])
                 mf *= P**e
                 continue
-            # Pe_out.append([P, max(e, self_fact_e[i])])
             mf *= P**max(e, self_fact_e[i])
             del self_fact_P[i]
             del self_fact_e[i]
@@ -292,6 +290,9 @@ def lcm(self, other) -> "Modulus":
         return Modulus(mf, inf, check=False)
 
     def divides(self, other) -> bool:
+        """
+        missing documentation
+        """
         if not set(self.infinite_part()).issubset(other.infinite_part()):
             return False
         return self.finite_part().divides(other.finite_part())
@@ -324,12 +325,6 @@ def finite_factors(self):
             self._finite_factors = self.finite_part().factor()
             return self._finite_factors
 
-    # def _pari_finite_factors(self):
-    #    """
-    #    Return
-    #    """
-    #    return self._number_field.pari_nf().idealfactor(self._finite)
-
     def equivalent_coprime_ideal_multiplier(self, I, other):
         r"""
         Given ``I`` coprime to this modulus `m`, return a number field element `\beta`
@@ -394,7 +389,7 @@ def equivalent_ideal_coprime_to_other(self, I, other):
         """
         return self.equivalent_coprime_ideal_multiplier(I, other) * I
 
-    def number_is_one_mod_star(self, a):
+    def number_is_one_mod_star(self, a) -> bool:
         """
         missing documentation
         """
@@ -430,7 +425,10 @@ def fix_signs(self, a):
         return t * a
 
     def get_one_mod_star_finite_with_fixed_signs(self, positive, negative):
-        if len(negative) == 0:
+        """
+        missing documentation
+        """
+        if not negative:
             return self.number_field().one()
         negative = tuple(negative)
         try:
@@ -485,10 +483,10 @@ def _signs(self, b):
         sigmas = self._number_field.real_places()
         return [ZZ.one() if sigmas[i](b).sign() == -1 else ZZ.zero() for i in self.infinite_part()]
 
-    def is_finite(self):
+    def is_finite(self) -> bool:
         return len(self._infinite) == 0
 
-    def is_infinite(self):
+    def is_infinite(self) -> bool:
         return self._finite.is_one()
 
     def __pari__(self):
@@ -518,7 +516,7 @@ def __pari__(self):
             inf_mod[pari_index] = 1
         return pari([self._finite, inf_mod])
 
-    def __hash__(self):
+    def __hash__(self) -> int:
         """
         Return the hash of ``self``.
         """
@@ -676,7 +674,7 @@ def inverse(self):
 
     __invert__ = inverse
 
-    def is_principal(self):
+    def is_principal(self) -> bool:
         r"""
         Return ``True`` iff this ideal class is the trivial (principal) class.
 
@@ -923,10 +921,6 @@ def ideal(self, reduce=True):
                     I = R.ideal_reduce(I)
         return I
 
-    # def reduce(self):
-    #    nf = self.parent()._number_field.pari_nf()
-    #    return RayClassGroupElement(self.parent(), self.exponents(), nf.idealred(self.value()))
-
 
 class SFractionalIdealClass(FractionalIdealClass):
     r"""
@@ -1197,7 +1191,7 @@ def _iter_inner(self, i0, k):
             i0 = i0 * gk
         return
 
-    def _repr_(self):
+    def _repr_(self) -> str:
         r"""
         Return string representation of ``self``.
 
@@ -1238,7 +1232,8 @@ def number_field(self):
 class RayClassGroup(AbelianGroup_class):
     Element = RayClassGroupElement
 
-    def __init__(self, gens_orders, names, modulus, gens, bnr, proof=True):
+    def __init__(self, gens_orders, names, modulus,
+                 gens, bnr, proof=True) -> None:
         r"""
         ``gens`` -- a tuple of pari extended ideals
         """
@@ -1433,6 +1428,7 @@ def _ideal_log(self, ideal):
 
     def ideal_reduce(self, ideal):
         """
+        missing documentation
         """
         ideal = pari(ideal)
         try:
@@ -1577,7 +1573,7 @@ def _element_constructor_(self, *args, **kwds):
                 raise TypeError("The zero ideal is not a fractional ideal")
             return self.element_class(self, None, I)
 
-    def _repr_(self):
+    def _repr_(self) -> str:
         r"""
         Return string representation of this S-class group.