Apply suggestions from code review

Co-authored-by: Copilot <[email protected]>

Author: cxzhong

.github/workflows/release.yml

@@ -43,7 +43,8 @@ jobs:
           make configure
           ./configure
       - name: make dist (--enable-download-from-upstream-url)
-        if: (success() || failure()) && steps.make_dist.outcome != 'success'
+        id: make_dist
+        if: success() || failure()
         run: |
           make dist
         env:

build/pkgs/rpds_py/SPKG.rst

@@ -9,7 +9,7 @@ Python bindings to the Rust rpds crate for persistent data structures.
 rpds-py provides efficient, immutable data structures including:
 
 * ``HashTrieMap`` - Persistent hash map
-* ``HashTrieSet`` - Persistent hash set  
+* ``HashTrieSet`` - Persistent hash set
 * ``List`` - Persistent list with efficient operations
 
 These data structures are backed by Rust implementations for high performance
@@ -53,7 +53,7 @@ versions and platforms:
 * Windows (win32, win_amd64, win_arm64)
 
 The Sage build system automatically selects and downloads the appropriate
-wheel for your platform and Python version using pip's auto-detection.
+wheel for your platform and Python version using the packaging library's compatibility tags.
 
 When building from source, a Rust toolchain is required as rpds-py contains
 Rust extensions for performance.

build/sage_bootstrap/package.py

@@ -258,7 +258,7 @@ def tarballs_info(self):
         """
         return self.__tarballs_info
 
-    def find_tarball_for_platform(self, python_version=None):
+    def find_tarball_for_platform(self):
         """
         Find the appropriate tarball for the current platform.
         

build/sage_bootstrap/tarball.py

@@ -16,8 +16,7 @@
 # ****************************************************************************
 
 import os
-import sys
-import subprocess
+
 import logging
 log = logging.getLogger()
 
@@ -60,7 +59,7 @@ def __init__(self, tarball_name, package=None, tarball_info=None):
         """
         self.__filename = tarball_name
         self.__tarball_info = tarball_info
-        
+
         if package is None:
             self.__package = None
             for pkg in Package.all():
@@ -343,7 +342,7 @@ def _download_single_wheel(self, tarball_info, allow_upstream=False):
                 log.debug('File not at upstream URL')
 
         if not successful_download:
-            raise FileNotMirroredError(f'Could not download {tarball_filename} from pip, mirrors, or upstream')
+            raise FileNotMirroredError(f'Could not download {tarball_filename} from mirrors or upstream')
 
         # Verify checksum of traditionally-downloaded file
         try:
@@ -355,7 +354,7 @@ def _download_single_wheel(self, tarball_info, allow_upstream=False):
             log.info(f'Successfully downloaded and verified: {tarball_filename}')
             # Update self to point to the actually downloaded file
             self.__filename = tarball_filename
-        except Exception as e:
+        except (ChecksumError, IOError, ValueError) as e:
             log.error(f'Error verifying downloaded tarball: {e}')
             raise