Skip to content

Commit 127a790

Browse files
committed
Revert changes in 83bc9d5
1 parent 83bc9d5 commit 127a790

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

src/ODataClient.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ protected function getDefaultPostProcessor()
131131

132132
/**
133133
* Gets the IAuthenticationProvider for authenticating requests.
134-
* @var IAuthenticationProvider
135134
*
136135
* @return Closure|IAuthenticationProvider
137136
*/
@@ -232,7 +231,6 @@ public function get($requestUri, $bindings = [])
232231
*
233232
* @param string $requestUri
234233
* @param array $bindings
235-
* @param array $skipToken
236234
*
237235
* @return IODataRequest
238236
*/

tests/ODataClientTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public function testODataClientSkipToken()
128128
$this->assertEquals($pageSize, $page2results->count());
129129
}
130130

131-
$lastPageSize = 5;
131+
$lastPageSize = 4;
132132
if ($page2skiptoken) {
133133
$page3response = $odataClient->from('People')->skiptoken($page2skiptoken)->get()->first();
134134
$page3results = collect($page3response->getResponseAsObject(Entity::class));
@@ -157,7 +157,7 @@ public function testODataClientCursorCountShouldEqualTotalEntitySetCount()
157157

158158
$data = $odataClient->from('People')->pageSize($pageSize)->cursor();
159159

160-
$expectedCount = 21;
160+
$expectedCount = 20;
161161

162162
$this->assertEquals($expectedCount, $data->count());
163163
}
@@ -196,7 +196,7 @@ public function testODataClientCursorLastShouldReturnEntityKristaKemp()
196196

197197
$last = $data->last();
198198
$this->assertInstanceOf(Entity::class, $last);
199-
$this->assertEquals('Seymour', $last->UserName);
199+
$this->assertEquals('kristakemp', $last->UserName);
200200
}
201201

202202
public function testODataClientCursorSkip1FirstShouldReturnEntityScottKetchum()
@@ -273,7 +273,7 @@ public function testODataClientCursorSkip16LastPageShouldBe4Records()
273273
$data = $odataClient->from('People')->pageSize($pageSize)->cursor();
274274

275275
$lastPage = $data->skip(16);
276-
$lastPageSize = 5;
276+
$lastPageSize = 4;
277277
$this->assertEquals($lastPageSize, count($lastPage->toArray()));
278278
}
279279

@@ -285,7 +285,7 @@ public function testODataClientCursorIteratingShouldReturnAll20Entities()
285285

286286
$data = $odataClient->from('People')->pageSize($pageSize)->cursor();
287287

288-
$expectedCount = 21;
288+
$expectedCount = 20;
289289
$counter = 0;
290290

291291
$data->each(function ($person) use(&$counter) {

tests/Query/BuilderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public function testEntitySetCount()
113113

114114
$entitySet = 'People';
115115

116-
$expected = 21;
116+
$expected = 20;
117117

118118
$actual = $builder->from($entitySet)->count();
119119

0 commit comments

Comments
 (0)