diff --git a/src/ODataClient.php b/src/ODataClient.php index 06275e2..a854b4a 100644 --- a/src/ODataClient.php +++ b/src/ODataClient.php @@ -131,7 +131,6 @@ protected function getDefaultPostProcessor() /** * Gets the IAuthenticationProvider for authenticating requests. - * @var IAuthenticationProvider * * @return Closure|IAuthenticationProvider */ @@ -232,7 +231,6 @@ public function get($requestUri, $bindings = []) * * @param string $requestUri * @param array $bindings - * @param array $skipToken * * @return IODataRequest */ diff --git a/tests/ODataClientTest.php b/tests/ODataClientTest.php index 7108325..3e0854c 100644 --- a/tests/ODataClientTest.php +++ b/tests/ODataClientTest.php @@ -128,7 +128,7 @@ public function testODataClientSkipToken() $this->assertEquals($pageSize, $page2results->count()); } - $lastPageSize = 5; + $lastPageSize = 4; if ($page2skiptoken) { $page3response = $odataClient->from('People')->skiptoken($page2skiptoken)->get()->first(); $page3results = collect($page3response->getResponseAsObject(Entity::class)); @@ -157,7 +157,7 @@ public function testODataClientCursorCountShouldEqualTotalEntitySetCount() $data = $odataClient->from('People')->pageSize($pageSize)->cursor(); - $expectedCount = 21; + $expectedCount = 20; $this->assertEquals($expectedCount, $data->count()); } @@ -196,7 +196,7 @@ public function testODataClientCursorLastShouldReturnEntityKristaKemp() $last = $data->last(); $this->assertInstanceOf(Entity::class, $last); - $this->assertEquals('Seymour', $last->UserName); + $this->assertEquals('kristakemp', $last->UserName); } public function testODataClientCursorSkip1FirstShouldReturnEntityScottKetchum() @@ -273,7 +273,7 @@ public function testODataClientCursorSkip16LastPageShouldBe4Records() $data = $odataClient->from('People')->pageSize($pageSize)->cursor(); $lastPage = $data->skip(16); - $lastPageSize = 5; + $lastPageSize = 4; $this->assertEquals($lastPageSize, count($lastPage->toArray())); } @@ -285,7 +285,7 @@ public function testODataClientCursorIteratingShouldReturnAll20Entities() $data = $odataClient->from('People')->pageSize($pageSize)->cursor(); - $expectedCount = 21; + $expectedCount = 20; $counter = 0; $data->each(function ($person) use(&$counter) { diff --git a/tests/Query/BuilderTest.php b/tests/Query/BuilderTest.php index a16f583..2282820 100644 --- a/tests/Query/BuilderTest.php +++ b/tests/Query/BuilderTest.php @@ -113,7 +113,7 @@ public function testEntitySetCount() $entitySet = 'People'; - $expected = 21; + $expected = 20; $actual = $builder->from($entitySet)->count();