Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor code to split laravel and odata logic #68

Open
strorch opened this issue Dec 9, 2020 · 1 comment
Open

refactor code to split laravel and odata logic #68

strorch opened this issue Dec 9, 2020 · 1 comment

Comments

@strorch
Copy link

strorch commented Dec 9, 2020

Hello,

Thank you for creating this project, its very good!

I think that it will be really nice to refactor code which will do all package functionality with psr http standards.
I found a list of ideas that for my opinion can make it more usable and allow to use package easy in pure php project:

1) Create a package which contains query builder logic

2) Create a package which configurates http client with psr http standards(7, 17 and 18).

Create code which will manipulate only Psr\Http interfaces, also create possibility to configure it with ContainerInterface(psr 11).
For example in ODataClient has dependencies from uri and auth provider, but its wrong, because its a request dependencies.

3) Create laravel adapter package which will manipulate with Illuminate\Support\Collection class

Its only ideas but I think it will be really good for using it in pure php projects or projects which will not have Laravel dependencies.

@Dicebar
Copy link

Dicebar commented Oct 19, 2022

Number three in particular would be great.

The package illuminate/collections includes global helper functions with relatively simple names like value(), which inevitably leads to conflicts when combined with functional programming and/or older code bases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants