Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some remarks #1

Open
Albert221 opened this issue Aug 8, 2020 · 1 comment
Open

Some remarks #1

Albert221 opened this issue Aug 8, 2020 · 1 comment

Comments

@Albert221
Copy link

Albert221 commented Aug 8, 2020

Hi! I'm reading your FCM tutorial and I have few remarks that I wanted to share with you.


even though some fields are optional, not adding them might cause some problems

It would be really nice and educational if you provided some examples of those problems or linked to articles explaining them


This is an important file and you should not push this

That's about google-services.json. That's quite untrue. Look here: https://groups.google.com/forum/#!msg/firebase-talk/bamCgTDajkw/uVEJXjtiBwAJ


Background message handling is intended to be performed quickly

This quote could be put in the next section on Adding FCM libraries, as the previous section doesn't mention background messages.


Create an Application file under <app-name>/android/app/src/main/java/<app-organization-path>/

Why not under main/kotlin? Flutter create creates this directory by default too IIRC.


It would be really nice to have a short description on why is the UNUserNotificationCenterDelegate part of the code needed in Swift. It would nicely extend the firebase_messaging README.


A description of what actually is a background message would be appreciated.

@salihgueler
Copy link
Owner

Hi Albert, thank you for your input on this.

I have some action points out of what you shared and some answers for you. I will share them separated below so you can track the progress. I am swamped at the moment, it might take couple of days to fix those :)

Answers

  • This is an important file and you should not push this

I believe you are misinterpreting what the Firebase engineer is saying here. This file is your configuration file and when you have an open-source project with the exact same file, people might just use your quota.

The file itself can be obtained by even simple APK reverse engineering yes, but still the main concern is keeping your quota for your team and yourself. So yes, you can technically put it to your repository and share with your teammates but would it be feasible. That is debatable.

You can see huge discussions here and for me, this means, in general, do not put your configuration files into your repositories.

So that means, it is not quite untrue :) It changes according to the case ;)

Actions

  • Add clarification and example for not adding the fields
  • Change the file directory from using java to kotlin
  • Add description for background messages
  • Add explanation about UNUserNotificationCenterDelegate
  • Explain what does background work mean and move quote under that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants