Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml files carry too much logic #125

Open
javierbertoli opened this issue Sep 23, 2016 · 1 comment
Open

yaml files carry too much logic #125

javierbertoli opened this issue Sep 23, 2016 · 1 comment

Comments

@javierbertoli
Copy link
Member

The formula's yaml files are carrying too much logic for files that must let you, at a quick glance, understand what values are being set as default or overriden in each of those files.

Even more, some of logic in these files, which should be loaded before pillars, are querying pillar values to construct variables or include values.

My understanding is that these files should just contain variables' assignments like here, have as little jinja as possible (like simple sets to avoid repetition) and then let map.jinja do all the magic.

@iggy
Copy link
Contributor

iggy commented Oct 15, 2016

Agreed... This really isn't in the spirit that we originally had in putting some of this stuff into yaml to begin with. The original "shoving everything into map.jinja" way was impossible to read. This has just come full circle to be impossible to read again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants