[FEATURE REQUEST] Abitlity to make secured connections in pillar_ldap

[kevkha]

Is your feature request related to a problem? Please describe.
We need to get ldaps working but salt.pillar.pillar_ldap does not support uri from this line of code.

Describe the solution you'd like
if uri is defined in pillar_ldap.yaml it should override both server and port

schema = "ldaps" if tls else "ldap"
  if connargs["uri"] == ""
    connargs["uri"] = "{}://{}:{}".format(schema, connargs["server"], connargs["port"])

Describe alternatives you've considered
Alternately, change code to support uri only

secured connections

acme-user:
  uri:       ldaps://auth.acme.com:636
  tls:       true

or unsecured connections

acme-user:
  uri:       ldap://auth.acme.com:389
  tls:       false

Additional context
Example of pillar_ldap.yaml

acme-user:
  uri:       ldaps://auth.acme.com:636
  server:    auth.acme.com
  port:      636
  tls:       true

Please Note
If this feature request would be considered a substantial change or addition, this should go through a SEP process here https://github.com/saltstack/salt-enhancement-proposals, instead of a feature request.

[welcome[bot]]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Community Wiki
• Salt’s Contributor Guide
• Join our Community Slack
• IRC on LiberaChat
• Salt Project YouTube channel
• Salt Project Twitch channel

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

[Frizlab]

Fully agree, it’s very weird not to have ldaps support since a few years ago already, especially since LDAP with STARTTLS should be considered a bad practice.

[Frizlab]

FWIW the patch could be as simple as

--- /usr/lib/python2.7/dist-packages/salt/pillar/pillar_ldap_old.py	2023-11-16 11:42:37.795149374 +0000
+++ /usr/lib/python2.7/dist-packages/salt/pillar/pillar_ldap.py	2023-11-16 11:43:24.423235480 +0000
@@ -274,7 +274,7 @@
     '''
     # Build LDAP connection args
     connargs = {}
-    for name in ['server', 'port', 'tls', 'binddn', 'bindpw', 'anonymous']:
+    for name in ['uri', 'server', 'port', 'tls', 'binddn', 'bindpw', 'anonymous']:
         connargs[name] = _config(name, conf)
     if connargs['binddn'] and connargs['bindpw']:
         connargs['anonymous'] = False