Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[youtube] block or inline? #3

Open
alex-georgiou opened this issue Oct 24, 2013 · 1 comment
Open

[youtube] block or inline? #3

alex-georgiou opened this issue Oct 24, 2013 · 1 comment

Comments

@alex-georgiou
Copy link

I had a situation where a user had entered into SCEditor a youtube video inside some other formatting tags ([b],[i]) and the rendering to HTML was throwing an exception. Digging around I found out that in classes/Node/Container/Document.php the [youtube] tag is defined as block. I changed the constructor's third parameter to BBCode::INLINE_TAG and it solved my immediate problem.

Does youtube really need to be block-level? I'm asking because if this is the case, then the WYSIWYG part of SCEditor should also make sure to produce correct bbcode that can be parsed by SBBCodeParser.

Thanks

@Khalilbz
Copy link

Me too I don't see that it should be a block-level so I changed all the block level tags to INLINE_TAG specially the URL Tag :) :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants