Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with DOMMatrix polyfill ? #129

Open
renambot opened this issue Dec 10, 2022 · 0 comments
Open

Problem with DOMMatrix polyfill ? #129

renambot opened this issue Dec 10, 2022 · 0 comments

Comments

@renambot
Copy link

renambot commented Dec 10, 2022 •
edited
Loading

Wondering if there's a bug in the toSkMatrix function.
I think maybe if (jsMatrix instanceof geometry.DOMMatrix)
should be if (jsMatrix instanceof DOMMatrix)

I'm rendering a PDF file (with PDFjs lib) using skia-canvas and it works fine, except sometimes it crashes in toSkMatrix function, because there's no 'true' path in the tests. If I update with jsMatrix instanceof DOMMatrix it works fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@renambot