Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logging to SLF4J #98

Open
patrickskowronekdkfz opened this issue Dec 13, 2021 · 1 comment
Open

Change logging to SLF4J #98

patrickskowronekdkfz opened this issue Dec 13, 2021 · 1 comment
Assignees
@DenisKoether
Labels
refactoring

Comments

@patrickskowronekdkfz
Copy link
Contributor

In the pom.xml there is a comment stating "TODO: Change logging to SLF4J ???"

Should we do that or change the loggin from log4j 2 to slf4j or chage it to another lib?
@alexanderkiel @torbrenner @TasDeniz
@alexanderkiel
Copy link
Member

slf4j is a logging API which is widely used in Java. I would update all apps and libs to use that API. After that, I would use slf4j's own logging backend logback instead of log4j.

@DenisKoether DenisKoether self-assigned this Dec 15, 2021
TasDeniz added a commit that referenced this issue Dec 23, 2021
@TasDeniz
Merge pull request #118 from samply/feature/#98-slf4j-refactoring
203bdd2 
Feature/#98 slf4j refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenisKoether DenisKoether

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexanderkiel @patrickskowronekdkfz @DenisKoether