Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator: separate packages from imports #11

Open
samuel opened this issue May 22, 2013 · 1 comment
Open

generator: separate packages from imports #11

samuel opened this issue May 22, 2013 · 1 comment
Assignees

Comments

@samuel
Copy link
Owner

samuel commented May 22, 2013

Right now the generator can only create a single Go file which includes all imports. It would be good to be able to create separate packages from the imports instead of bundling. This would allow for multiple uses of the imports, and it would fix some import namespace issues.

@ghost ghost assigned samuel May 22, 2013
@dmcgowan
Copy link

When includes are involved there are likely multiple thrift interfaces sharing the include, if you generated the include package automatically you may end up generating it twice. Would it be easier to have the generator look at the include but not automatically generate, or even have a command line option to toggle this behavior. For my particular use case it is easier to call generate on each .thrift file without worrying about side effects on each generation. Another option could be just supporting multiple input files to the generator, then you could just run command like ./generator *.thrift -outputdir src.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants