Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more than 64 fields in a struct #62

Open
samuel opened this issue Sep 25, 2015 · 3 comments
Open

Support more than 64 fields in a struct #62

samuel opened this issue Sep 25, 2015 · 3 comments

Comments

@samuel
Copy link
Owner

samuel commented Sep 25, 2015

Currently a uint64 is used to track required fields. This limits a struct to fields with ID < 64. Ideally this limit should be removed.
@samuel samuel mentioned this issue Sep 25, 2015
Closed
@alecthomas
Copy link
Contributor

Is this still an issue?

alecthomas added a commit to alecthomas/go-thrift that referenced this issue Apr 7, 2016
@alecthomas
JSON tag AST fields + use bitset for tracking required.
301b1af 
Fixes samuel#62.
@samuel
Copy link
Owner Author

samuel commented Apr 7, 2016

Unfortunately so: https://github.com/samuel/go-thrift/blob/master/thrift/thrift.go#L204

@lc0
Copy link

lc0 commented Sep 2, 2016

@alecthomas thanks for your PR, for now, will use your branch.
@samuel could we please merge it? Sounds like a reasonable change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samuel @alecthomas @lc0