Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag variables should be passed to GoGenerator explicitly so that it is easy to call into go-thrift programmatically #67

Open
colonelpanic8 opened this issue Oct 14, 2015 · 0 comments
Open

Flag variables should be passed to GoGenerator explicitly so that it is easy to call into go-thrift programmatically #67

colonelpanic8 opened this issue Oct 14, 2015 · 0 comments

Comments

@colonelpanic8
Copy link

IMO, the only place that it is appropriate to use flag variables is in a main function. From that point onward they should be passed to the objects as configuration.

Is there any reason that the flag variables flagGoImportPrefix is not set in main and passed to the generator?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colonelpanic8