Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

theme_color in manifest but not index.html #71

Open
topaxi opened this issue Oct 16, 2017 · 2 comments
Open

theme_color in manifest but not index.html #71

topaxi opened this issue Oct 16, 2017 · 2 comments
Labels

Comments

@topaxi
Copy link

topaxi commented Oct 16, 2017

Is there a way to define the theme_color in the manifest only? I'm setting the theme_color meta element programmatically through ember-cli-head depending on my backgrounds and don't want a duplicate meta element in my head.

@san650
Copy link
Owner

san650 commented Oct 16, 2017

There's no way to disable the generation of the theme_color meta at the moment. Sorry about that.

Is there a possibility that you use the theme_color generated by ember-web-app and update it when the ember app boots? Instead of using ember-cli-head.

I guess we could offer a blacklist mechanism on this addon to avoid generating unwanted meta tags, maybe through ember-cli-build.js config flag...

var EmberApp = require('ember-cli/lib/broccoli/ember-app');

module.exports = function(defaults) {
  var options = {
    'ember-web-app': {
      'disable-theme-meta': true
    }
  };

  var app = new EmberApp(defaults, options);

  return app.toTree();
};

or something like this.

Maybe we should think on a way to disable fallbacks altogether.

@topaxi
Copy link
Author

topaxi commented Oct 17, 2017

I thought of updating it manually, but that would require DOM manipulation which is not available in FastBoot. Would definitely be nice to blacklist unwanted meta tags.

Maybe have an override for each target?

module.exports = function() {
  return {
    name: "Theme color manifest",
    theme_color: "#ffa105",

    apple: {
      statusBarStyle: 'black-translucent'
    },

    html: { // or `meta`
      theme_color: null
    }
  }
}

@san650 san650 added the feature label Nov 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants