-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn back on notebook tests #531
Comments
Additional context (clawed deep from memory): IIRC these didn't start failing because of any code changes we made directly, but rather because for whatever reason some cells started randomly taking forever to run, eventually timing out. We concluded that the most likely explanation (since none of the devs at the time could reproduce the behavior locally) was that some combination of package versions being installed on the runners was colliding in a manner that behaved badly. We spent a while comparing pip installation logs from before and after this issue started and didn't make any headway at that time. If our hypothesis was correct then this is a prime candidate for an issue that would have magically fixed itself given enough time. |
Thanks for that, it jogged my memory as well... I'll try to turn those on in my runner testing branch and either confirm we are still having issues or if it automagically resolved itself. |
I happened across my notes for this from June 7 2024 😅 Not sure it will be useful, but for posterity:
|
[like] Murray, Riley John reacted to your message:
…________________________________
From: Stefan Seritan ***@***.***>
Sent: Friday, January 24, 2025 8:38:41 PM
To: sandialabs/pyGSTi ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [EXTERNAL] Re: [sandialabs/pyGSTi] Turn back on notebook tests (Issue #531)
I happened across my notes for this from June 7 2024 😅 Not sure it will be useful, but for posterity:
Package Mac 3.8 (June 6, passed) Mac 3.9 (May 20, passed) Mac 3.9 (June 6, failed) Package update dates
numpy 1.24.4 1.26.4 1.26.4
*scipy 1.10.1 1.13.0 1.13.1 *1.13.1 -> May 22
pandas 2.0.3 2.2.2 2.2.2
pytest 8.2.2 8.2.1 8.2.2
matplotlib 3.7.5 3.9.0 3.9.0
cirq-core 1.1.0 1.3.0 1.3.0
ipython 8.12.3 8.18.1 8.18.1
sympy 1.12.1 1.12 1.12.1
networkx 2.8.8 3.2.1 3.2.1
typing-extensions 4.12.1 4.11.0 4.12.1
osqp 0.6.7 0.6.5 0.6.7
clarabel 0.9.0 0.7.1 0.9.0
scs 3.2.4.post2 3.2.4.post1 3.2.4.post2
anyio 4.4.0 4.3.0 4.4.0
jupyter_client 8.6.2 8.6.1 8.6.2
*tornado 6.4 6.4 6.4.1 6.4.1 -> June 6
coverage 7.5.3 7.5.1 7.5.3
jupyterlab_server 2.27.2 2.27.1 2.27.2
jupyterlab 4.2.1 4.2.1 4.2.0
zipp 3.19.2 3.18.2 3.19.2
requests 2.32.3 2.32.0 2.32.3
certifi 2024.6.2 2024.2.2 2024.6.2
webcolors 24.6 1.13 24.6
—
Reply to this email directly, view it on GitHub<#531 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACRLIFFHLDOKKBJXYERXC6T2MKQFDAVCNFSM6AAAAABVTNHG3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJTGM2DAMJWGQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Currently, the notebook tests are off on beta and master with a comment that they started failing in May 2024. We should re-evaluate those failures and turn these tests back on.
The text was updated successfully, but these errors were encountered: