Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directories dependency does not work on Windows #27

Closed
jonahbeckford opened this issue Feb 15, 2024 · 4 comments · Fixed by #29
Closed

directories dependency does not work on Windows #27

jonahbeckford opened this issue Feb 15, 2024 · 4 comments · Fixed by #29

Comments

@jonahbeckford
Copy link
Contributor

The last version of bogue pulled in the directories package. The problem is that package does not work on Windows: OCamlPro/directories#14

That's stuck because xdg has become the standard (its logic has made its way into the ocaml compiler for profile calculation). And the authors don't have access to a Windows machine.

Thoughts?
@sanette
Copy link
Owner

sanette commented Feb 15, 2024

Well, that's too bad because I remember we switched to directories precisely because we thought it would handle better cross-platform config dirs...
I guess we could switch back to the old scheme

@jonahbeckford
Copy link
Contributor Author

https://v3.ocaml.org/p/xdg/latest/doc/index.html works in both Windows and Unix.

@sanette
Copy link
Owner

sanette commented Feb 15, 2024 •
edited
Loading

wouldn't xdg pull in the whole dune as a runtime dependency?
(this is a naive question; I don't know what binaries really include)
(for the moment, dune is used only for building)

@jonahbeckford
Copy link
Contributor Author

No, it has no runtime dependencies ... just like directories. https://github.com/ocaml/dune/blob/main/xdg.opam

I will send you a PR.

jonahbeckford added a commit to jonahbeckford/bogue that referenced this issue Feb 15, 2024
@jonahbeckford
Switch [directories] to [xdg] to work on Windows
4dcab58 
xdg.3.4.0 was the first version to have good Windows defaults.

It should be the same configuration directory on Linux but not Windows (which was never working) and not macOS. macOS used to be $HOME/Library/Application Support/<project_path> where <project_path> was qualifier.organization.application (org.sanette.bogue).

Fixes sanette#27
@jonahbeckford jonahbeckford mentioned this issue Feb 15, 2024
Merged
sanette pushed a commit that referenced this issue Feb 17, 2024
@jonahbeckford
Switch [directories] to [xdg] to work on Windows (#29)
ad184ee 
* Switch [directories] to [xdg] to work on Windows

xdg.3.4.0 was the first version to have good Windows defaults.

It should be the same configuration directory on Linux but not Windows (which was never working) and not macOS. macOS used to be $HOME/Library/Application Support/<project_path> where <project_path> was qualifier.organization.application (org.sanette.bogue).

Fixes #27

* Use // for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch [directories] to [xdg] to work on Windows jonahbeckford/bogue
2 participants
@sanette @jonahbeckford