Before printing barcodes, convert to the right format depending on how

it was originally stored.

Author: emrojo

app/models/asset.rb

@@ -174,13 +174,13 @@ def study_name
     return ''
   end
 
-  def machine_barcode?
+  def print_machine_barcode?
     facts.where(predicate: 'barcodeFormat', object: 'machine_barcode').count > 0
   end
 
   def barcode_formatted_for_printing
-    if machine_barcode?
-      mbarcode = SBCF::SangerBarcode.from_human(barcode).machine_barcode
+    if print_machine_barcode?
+      mbarcode = TokenUtil.machine_barcode(barcode)
       return mbarcode if mbarcode
     end
     barcode
@@ -202,7 +202,7 @@ def printable_object(username = 'unknown')
     return {:label => {
       :barcode => barcode_formatted_for_printing,
       :barcode2d => barcode_formatted_for_printing,
-      :top_line => barcode,
+      :top_line => TokenUtil.human_barcode(barcode),
       :middle_line => kit_type,
       :bottom_line => info_line
       }

lib/token_util.rb

@@ -7,6 +7,30 @@ def self.fluidx_barcode_prefix
     'F'
   end
 
+  def self.MACHINE_BARCODE
+    /^\d*$/
+  end
+
+  def self.machine_barcode?(barcode)
+    return false if barcode.nil?
+    barcode.to_s.match?(TokenUtil.MACHINE_BARCODE)
+  end
+
+  def self.human_barcode?(barcode)
+    return false if barcode.nil?
+    !barcode.to_s.match?(TokenUtil.MACHINE_BARCODE)
+  end
+
+  def self.machine_barcode(barcode)
+    return barcode.to_s if machine_barcode?(barcode)
+    SBCF::SangerBarcode.from_human(barcode).machine_barcode.to_s
+  end
+
+  def self.human_barcode(barcode)
+    return SBCF::SangerBarcode.from_machine(barcode).human_barcode if machine_barcode?(barcode)
+    barcode
+  end
+
   def self.WILDCARD_REGEXP
     /\?\w*/
   end

spec/lib/token_util_spec.rb

@@ -97,4 +97,52 @@
       end
     end
   end
+
+  context '#machine_barcode' do
+    it 'returns the barcode to_s if the barcode is already machine barcode' do
+      expect(TokenUtil.machine_barcode(3981337734769)).to eq("3981337734769")
+    end
+    it 'returns the barcode if the barcode is already machine barcode' do
+      expect(TokenUtil.machine_barcode("3981337734769")).to eq("3981337734769")
+    end
+    it 'returns the converted barcode if is not a machine barcode' do
+      expect(TokenUtil.machine_barcode("NT1337734L")).to eq("3981337734769")
+    end
+  end
+
+  context '#human_barcode' do
+    it 'returns the human barcode if the barcode is already human barcode' do
+      expect(TokenUtil.human_barcode("D12345678")).to eq("D12345678")
+    end
+    it 'returns the converted barcode from numeric machine barcode' do
+      expect(TokenUtil.human_barcode(3981337734769)).to eq("NT1337734L")
+    end
+    it 'returns the converted barcode from string machine barcode' do
+      expect(TokenUtil.human_barcode("3981337734769")).to eq("NT1337734L")
+    end
+  end
+
+  context '#machine_barcode?' do
+    it 'returns true if the barcode is machine barcode numeric' do
+      expect(TokenUtil.machine_barcode?(12345678)).to eq(true)
+    end
+    it 'returns true if the barcode is machine barcode string' do
+      expect(TokenUtil.machine_barcode?("12345678")).to eq(true)
+    end
+    it 'returns false any other case' do
+      expect(TokenUtil.machine_barcode?("D12345678")).to eq(false)
+    end
+  end
+
+  context '#human_barcode?' do
+    it 'returns true if the barcode is human barcode' do
+      expect(TokenUtil.human_barcode?("D12345678")).to eq(true)
+    end
+    it 'returns false if machine barcode numeric' do
+      expect(TokenUtil.human_barcode?(12345678)).to eq(false)
+    end
+    it 'returns false if machine barcode string' do
+      expect(TokenUtil.human_barcode?("12345678")).to eq(false)
+    end
+  end
 end

spec/models/asset_spec.rb

@@ -26,15 +26,15 @@
     end
   end
 
-  context '#machine_barcode?' do
+  context '#print_machine_barcode?' do
     let(:asset) { create(:asset)}
     it 'returns true when the asset has a barcode format of machine barcode' do
       asset.facts << create(:fact, predicate: 'barcodeFormat', object: 'machine_barcode',
         literal: true)
-      expect(asset.machine_barcode?).to be_truthy
+      expect(asset.print_machine_barcode?).to be_truthy
     end
     it 'returns false when the asset does not have a setting' do
-      expect(asset.machine_barcode?).to be_falsy
+      expect(asset.print_machine_barcode?).to be_falsy
     end
   end
 
@@ -55,7 +55,7 @@
       end
       context 'when we can generate the machine barcode' do
         it 'returns the machine barcode' do
-          expect(asset.barcode_formatted_for_printing).to eq(machine_barcode)
+          expect(asset.barcode_formatted_for_printing).to eq(machine_barcode.to_s)
         end
       end
     end
@@ -95,10 +95,10 @@
           expect(asset.printable_object[:label][:top_line]).to eq(human_barcode)
         end
         it 'prints the machine barcode as barcode' do
-          expect(asset.printable_object[:label][:barcode]).to eq(machine_barcode)
+          expect(asset.printable_object[:label][:barcode]).to eq(machine_barcode.to_s)
         end
         it 'prints the machine barcode as barcode 2d' do
-          expect(asset.printable_object[:label][:barcode2d]).to eq(machine_barcode)
+          expect(asset.printable_object[:label][:barcode2d]).to eq(machine_barcode.to_s)
         end
       end
     end