Skip to content

Y25-170 - [Epic / Needs refinement] As a developer (Ben) I would like to refactor the way selected labware and used aliquots are used in the Pacbio pool creation process. #2229

@BenTopping

Description

@BenTopping

User story
This is currently a large but may be able to be broken down hence Epic / needs refinement

We currently combine requests and aliquots into one object to help refer back to the selected labware and access the request data like sample_name from the aliquot. The used_aliquots could just be the plain service object and any additional data could be dynamically loaded / associated. This will help with simplifying pool setup, pool creation and data manipulation.

Lots of complex aggregation going on in src/stores/utilities/pool.js.

Review PacbioLabwareSelectedList. Some complex processing going on here to select requests, shouldn't need to be this complicated.

We treat tubes with samples and tubes with libraries similarly but this adds complex checks. We should treat libraries separately from tubes.

Who are the primary contacts for this story

Ben T, Seena N

Acceptance criteria

Consider if these features can be featured flagged to decouple testing and deployment.
To be considered successful the solution must allow:

  • Identify improvements for linking selected labware and pool used aliquots together. E.g. dynamically identify relationships based on aliquot source type.
  • Using the above identifications refactor the pacbioPoolCreate store and src/stores/utilities/pool.js utility.
  • Ensure all existing behaviour is unbroken.

Additional context

This story came out of sanger/traction-service#1493 as an improvement.

Metadata

Metadata

Assignees

No one assigned

    Labels

    EnhancementNew feature or requestSize: LLarge - large effort & riskTechnical DebtTechnical debtValue: 2Value to the insitute is low

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions