Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: update Args to support Chat Input commands #494

Open
1 task done
favna opened this issue Jul 24, 2022 · 1 comment · May be fixed by #728
Open
1 task done

request: update Args to support Chat Input commands #494

favna opened this issue Jul 24, 2022 · 1 comment · May be fixed by #728

Comments

@favna
Copy link
Member

favna commented Jul 24, 2022

Is there an existing issue or pull request for this?

  • I have searched the existing issues and pull requests

Feature description

When we first wrote Sapphire we added support for Arguments for message-based commands, however, they were never updated for Chat Input commands in version 3 as we had to cut it in order to be able to ship v3 sooner. That means it is moved to the scope of v4 and this issue is to track this feature.

Desired solution

Arguments has to be updated to support Chat Input commands

Alternatives considered

  • Only using the resolvers for Chat Input commands. As resolvers already make the backbone of Arguments and Chat Input command arguments are only really relevant for String type Chat Input commands the string content could easily be parsed by resolvers.
    • This is a valid argument, however supporting Arguments will allow more syntactic sugar and allow for less code to achieve the same.,

Additional context

No response

@favna
Copy link
Member Author

favna commented Feb 17, 2024

Copying the following blurb from #646

@vladfrangu has added to this topic:

bc I want to make args have a consistent interface between types
Basically make Args an interface now
and then MessageArgs/ChatInputCommandArgs implement it
and then people can just
use it
without thinking of what they are using it in
also it's hella breaking LOL sapphire v5 lets GOO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment