feat: change get-failed-info step SD-1405

Author: sowecthal

charts/tekton-pipelines/Chart.yaml

@@ -6,7 +6,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 2.2.14-dev.1
+version: 2.2.14-dev.2
 
 maintainers:
   - url: https://www.saritasa.com/

charts/tekton-pipelines/README.md

@@ -31,7 +31,7 @@ saritasa-tekton-pipelines
 
 ## `chart.version`
 
-![Version: 2.2.14-dev.1](https://img.shields.io/badge/Version-2.2.14-dev.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
+![Version: 2.2.14-dev.2](https://img.shields.io/badge/Version-2.2.14-dev.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
 
 ## Maintainers
 

charts/tekton-pipelines/templates/common/tasks/slack-notification.yaml

@@ -49,30 +49,39 @@ spec:
       script: |
         #!/bin/sh
 
+        status="`echo $(params.status) | tr '[:upper:]' '[:lower:]'`"
+
+        # Exit early if deploy succeeded
+        if [ "$status" = "succeeded" ]; then
+          echo "Deploy succeeded, no failed tasks to analyze"
+          exit 0
+        fi
+
         pipelinerun_name=$(awk -F= '$1 == "tekton.dev/pipelineRun" {gsub(/"/, "", $2); print $2}' /etc/podinfo/labels)
 
         # Get names of taskRuns from the pipelineRun
         taskruns=$(kubectl -n ci get pipelinerun $pipelinerun_name -o json | jq -r '.status.childReferences[]?.name')
 
-        # Get names of failed task and step from the taskRun
+        # Get names of failed pod, task and step from the taskRuns
         for taskrun_name in $taskruns; do
           kubectl -n ci get taskrun $taskrun_name -o json |
           jq -r 'select(.status.conditions[0].reason == "Failed") |
-          { pod: .status.podName, task: .metadata.labels["tekton.dev/pipelineTask"], step: (.status.steps[]? | select(.terminated.reason == "Error") | .name)}' \
+          { pod: .status.podName, 
+            task: .metadata.labels["tekton.dev/pipelineTask"], 
+            step: (.status.steps[]? | select(.terminated.reason == "Error" and (.terminationReason != "Skipped")) | .name)}' \
           >> $(results.failed_info.path)
         done
 
         failed_pod_name=$(cat $(results.failed_info.path) | jq '.pod' -r)
         failed_task=$(cat $(results.failed_info.path) | jq '.task' -r)
         failed_step=$(cat $(results.failed_info.path) | jq '.step' -r)
 
-        # Fetch logs and save info about the failed task
         if [ -n "$failed_pod_name" ] && [ -n "$failed_step" ]; then
+          # Fetch logs and save info about the failed task
+          echo "Fetching logs for failed task: ${failed_task}, step: ${failed_step}"
+          curl -sk "https://tekton-logs-server.ci.svc.cluster.local/logs/ci/${failed_pod_name}/step-${failed_step}" | tail -c 1982 > $(results.logs.path)
           echo $failed_task > $(results.failed_task.path)
           echo $failed_step > $(results.failed_step.path)
-
-          echo "Fetching logs from: $logs_url"
-          curl -sk "https://tekton-logs-server.ci.svc.cluster.local/logs/ci/${failed_pod_name}/step-${failed_step}" | tail -c 1982 > "$(results.logs.path)"
         fi
 
     - name: notification