fix: request command data and config files checking bug (#253)

* fix: request command data and config files checking bug * tests: fixed request parameter Co-authored-by: Krishna Acondy <[email protected]>
sasjs · Nov 21, 2020 · be11afe · be11afe
1 parent da84b2d
commit be11afe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/commands/request.js b/src/commands/request.js
@@ -26,7 +26,7 @@ export async function runSasJob(commandLine) {
   let dataJson
   let configJson
 
-  if (dataFilePath !== 'default') {
+  if (dataFilePath) {
     if (dataFilePath.split('.').slice(-1)[0] !== 'json') {
       throw new Error('Provided data file must be valid json.')
     }
@@ -40,7 +40,7 @@ export async function runSasJob(commandLine) {
     }
   }
 
-  if (configFilePath !== 'default') {
+  if (configFilePath) {
     if (configFilePath.split('.').slice(-1)[0] !== 'json') {
       throw new Error('Provided config file must be valid json.')
     }

diff --git a/test/commands/request/request.spec.js b/test/commands/request/request.spec.js
@@ -93,7 +93,7 @@ describe('sasjs request', () => {
         async () => {
           await expect(
             runRequest(
-              `request /Public/app/cli-tests-${timestamp}/runRequest/sendArr -d ${dataPathRel} -c default -t ${targetName}`
+              `request /Public/app/cli-tests-${timestamp}/runRequest/sendArr -d ${dataPathRel} -t ${targetName}`
             )
           ).resolves.toEqual(true)
           const rawData = await readFile(`${process.projectDir}/output.json`)
@@ -111,7 +111,7 @@ describe('sasjs request', () => {
         async () => {
           await expect(
             runRequest(
-              `request /Public/app/cli-tests-${timestamp}/runRequest/sendObj -d ${dataPathRel} -c default -t ${targetName}`
+              `request /Public/app/cli-tests-${timestamp}/runRequest/sendObj -d ${dataPathRel} -t ${targetName}`
             )
           ).resolves.toEqual(true)
           const rawData = await readFile(`${process.projectDir}/output.json`)
@@ -131,7 +131,7 @@ describe('sasjs request', () => {
         async () => {
           await expect(
             runRequest(
-              `request runRequest/sendArr -d ${dataPathRel} -c default -t ${targetName}`
+              `request runRequest/sendArr -d ${dataPathRel} -t ${targetName}`
             )
           ).resolves.toEqual(true)
 
@@ -150,7 +150,7 @@ describe('sasjs request', () => {
         async () => {
           await expect(
             runRequest(
-              `request runRequest/sendObj -d ${dataPathRel} -c default -t ${targetName}`
+              `request runRequest/sendObj -d ${dataPathRel} -t ${targetName}`
             )
           ).resolves.toEqual(true)