request.status is not correct (is never "playing")

[martinkirch]

Description

I'm trying to know if a request is currently playing, but request.status never returns playing (the queue's is_active() never returns true either)

Steps to reproduce

Put your own track in the following script :

q = request.queue()
main_output = output(mksafe(q))

r = request.create("Music/Quakers - Supa K- Heavy Tremors - 28 Zodiac.flac")

thread.run(every=0.2, { log("q.is_active=#{q.is_active()}, current is #{q.current()}, r.status: #{request.status(r)}")})
thread.run(delay=3., { q.push(r) })

Expected behavior

In the example script, printed status rotates between idle, ready and destroyed.
Should be idle, playing and destroyed.
I'd also expect q.is_active=true when the request is playing.

Log extracts

No response

Script extracts

No response

Liquidsoap version

Liquidsoap 2.3.2+dev (built with opam from repository tagged at 2.3.2)

Liquidsoap build config

* Liquidsoap version  : 2.3.2+dev

 * Compilation options
   - Release build       : false
   - Git SHA             : (none)
   - OCaml version       : 4.14.2
   - OS type             : Unix
   - Libs versions       : angstrom=0.16.1 asetmap=0.8.1 asn1-combinators=0.3.2 astring=0.8.5 base=v0.16.3 base.base_internalhash_types=v0.16.3 base.caml=v0.16.3 base.shadow_stdlib=v0.16.3 base64=3.5.1 bigarray=[distributed with Ocaml] bigarray-compat=1.1.0 bigstringaf=0.10.0 bos=0.2.1 bytes=[distributed with OCaml 4.02 or above] ca-certs=v1.0.0 camlp-streams camomile.lib=2.0 cohttp=v6.1.0 cohttp-lwt=v6.1.0 cohttp-lwt-unix=v6.1.0 conduit=8.0.0 conduit-lwt=8.0.0 conduit-lwt-unix=8.0.0 cry=1.0.3 cstruct=6.2.0 ctypes=0.23.0 ctypes-foreign=0.23.0 ctypes.stubs=0.23.0 curl=0.9.2 digestif.c=1.2.0 domain-name=0.4.1 dtools=0.4.6 dune-build-info=3.17.2 dune-private-libs.dune-section=3.17.2 dune-site=3.17.2 dune-site.private=3.17.2 duppy=0.9.5 eqaf=0.10 ffmpeg-av=1.2.4 ffmpeg-avcodec=1.2.4 ffmpeg-avdevice=1.2.4 ffmpeg-avfilter=1.2.4 ffmpeg-avutil=1.2.4 ffmpeg-swresample=1.2.4 ffmpeg-swscale=1.2.4 fileutils=v0.6.6 fmt=0.10.0 fpath=0.7.3 gen=1.1 gmap=0.3.0 http=v6.1.0 http.__private__.http_bytebuffer=v6.1.0 integers ipaddr=5.6.0 ipaddr-sexp=5.6.0 ipaddr.unix=5.6.0 kdf.hkdf=1.0.0 kdf.pbkdf=1.0.0 liquidsoap-lang=2.3.2 liquidsoap-lang.console=2.3.2 liquidsoap_builtins liquidsoap_core liquidsoap_ffmpeg liquidsoap_ndi liquidsoap_optionals liquidsoap_oss liquidsoap_prometheus liquidsoap_pulseaudio liquidsoap_runtime liquidsoap_sdl liquidsoap_sdl_log_level liquidsoap_stereotool liquidsoap_tls liquidsoap_yaml logs=0.7.0 logs.fmt=0.7.0 logs.lwt=0.7.0 lwt=5.9.1 lwt.unix=5.9.1 macaddr=5.6.0 magic-mime=1.3.1 mem_usage=0.1.2 memtrace=0.2.3 menhirLib=20240715 metadata=0.3.0 mirage-crypto=2.0.0 mirage-crypto-ec=2.0.0 mirage-crypto-pk=2.0.0 mirage-crypto-rng=2.0.0 mirage-crypto-rng.unix=2.0.0 mm=0.8.6 mm.audio=0.8.6 mm.base=0.8.6 mm.image=0.8.6 mm.midi=0.8.6 mm.video=0.8.6 ndi ocplib-endian ocplib-endian.bigstring ohex ppx_compare.runtime-lib=v0.16.0 ppx_hash.runtime-lib=v0.16.0 ppx_sexp_conv.runtime-lib=v0.16.0 prometheus=1.2 prometheus-app=1.2 ptime=1.2.0 ptime.clock=1.2.0 ptime.clock.os=1.2.0 pulseaudio=0.1.5 re=1.12.0 rresult=0.7.0 sedlex=3.3 seq=[distributed with OCaml 4.07 or above] sexplib0=v0.16.0 stdlib-shims=0.3.0 stereotool str=[distributed with Ocaml] stringext=1.6.0 threads=[distributed with Ocaml] threads.posix=[internal] tls=2.0.0 tsdl=v1.1.0 tsdl-image=0.5 tsdl-ttf=0.6 unix=[distributed with Ocaml] uri=4.4.0 uri-sexp=4.4.0 uri.services=4.4.0 x509=1.0.5 xml-light=2.5 yaml=3.2.0 yaml.bindings=3.2.0 yaml.bindings.types=3.2.0 yaml.c=3.2.0 yaml.ffi=3.2.0 yaml.types=3.2.0 zarith=1.14
   - architecture        : amd64
   - host                : x86_64-pc-linux-gnu
   - target              : x86_64-pc-linux-gnu
   - system              : linux
   - ocamlopt_cflags     : -O2 -fno-strict-aliasing -fwrapv -pthread -fPIC
   - native_c_compiler   : gcc -O2 -fno-strict-aliasing -fwrapv -pthread -fPIC -D_FILE_OFFSET_BITS=64
   - native_c_libraries  : -lm

 * Configured paths
   - mode              : default
   - standard library  : (set by dune-site)
   - scripted binaries : (set by dune-site)
   - rundir            : (set by dune-site)
   - logdir            : (set by dune-site)
   - user cache        : $HOME/.cache/liquidsoap (override with $LIQ_CACHE_USER_DIR)
   - system cache      : (set by dune-site) (override with $LIQ_CACHE_SYSTEM_DIR)
   - camomile files    : (set by dune-site)

 * Supported input formats
   - MP3               : no (requires mad)
   - AAC               : no (requires faad)
   - Ffmpeg            : yes
   - Flac (native)     : no (requires flac)
   - Flac (ogg)        : no (requires ogg)
   - Opus              : no (requires opus)
   - Speex             : no (requires speex)
   - Theora            : no (requires theora)
   - Vorbis            : no (requires vorbis)
   - WAV/AIFF          : yes (native)

 * Supported output formats
   - FDK-AAC           : no (requires fdkaac)
   - FFmpeg            : yes
   - MP3               : no (requires lame)
   - MP3 (fixed-point) : no (requires shine)
   - Flac (native)     : no (requires flac)
   - Flac (ogg)        : no (requires ogg)
   - Opus              : no (requires opus)
   - Speex             : no (requires speex)
   - Theora            : no (requires theora)
   - Vorbis            : no (requires vorbis)
   - WAV/AIFF          : yes (native)

 * Tags
   - AAC               : no (requires faad)
   - FFmpeg            : yes
   - FLAC (native)     : no (requires flac)
   - Flac (ogg)        : no (requires ogg)
   - Native decoder    : yes
   - Vorbis            : no (requires vorbis)

 * Input / output
   - ALSA              : no (requires alsa)
   - AO                : no (requires ao)
   - FFmpeg            : yes
   - JACK              : no (requires bjack)
   - NDI               : yes
   - OSS               : yes
   - Portaudio         : no (requires portaudio)
   - Pulseaudio        : yes
   - SRT               : no (requires srt)

 * Audio manipulation
   - FFmpeg            : yes
   - LADSPA            : no (requires ladspa)
   - Lilv              : no (requires lilv)
   - Samplerate        : no (requires samplerate)
   - SoundTouch        : no (requires soundtouch)
   - StereoTool        : yes

 * Video manipulation
   - camlimages        : no (requires camlimages)
   - FFmpeg            : yes
   - frei0r            : no (requires frei0r)
   - ImageLib          : no (requires imagelib)
   - SDL               : yes

 * MIDI manipulation
   - DSSI              : no (requires dssi)

 * Visualization
   - GD                : no (requires gd)
   - Graphics          : no (requires graphics)
   - SDL               : yes

 * Additional libraries
   - FFmpeg filters    : yes
   - FFmpeg devices    : yes
   - inotify           : no (requires inotify)
   - irc               : no (requires irc-client-unix)
   - jemalloc          : no (requires jemalloc)
   - lo                : no (requires lo)
   - memtrace          : yes
   - osc               : no (requires osc-unix)
   - ssl               : no (requires ssl)
   - sqlite3           : no (requires sqlite3)
   - tls               : yes
   - posix-time2       : no (requires posix)
   - windows service   : no (requires winsvc)
   - YAML support      : yes
   - XML playlists     : no (requires xmlplaylist)

 * Monitoring
   - Prometheus        : yes

Installation method

From OPAM

Additional Info

No response

[toots]

Unfortunately, it is never "playing". I think that it's the same reason as why we've removed on_air: the request can be used in multiple sources so there's not a single canonical way of marking the request as "playing".