Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File 99107-fail-01-06-10102 not actually wrong #367

Open
luciansmith opened this issue Mar 6, 2024 · 1 comment · May be fixed by #392
Open

File 99107-fail-01-06-10102 not actually wrong #367

luciansmith opened this issue Mar 6, 2024 · 1 comment · May be fixed by #392
Assignees

Comments

@luciansmith
Copy link
Member

luciansmith commented Mar 6, 2024

We test for error 99107 in the file 99107-fail-01-06-10102.xml, but the problem it detects is, I believe, not actually an error. The file defines a new namespace 'appear' and adds a listOfShapes in that namespace, but I believe this is perfectly legal XML, and doesn't impact the SBML specification at all.

<?xml version="1.0" encoding="UTF-8"?>
<sbml xmlns="http://www.sbml.org/sbml/level3/version2/core"  level="3" version="2"
xmlns:appear1="http://www.sbml.org/sbml/level3/version1/appear/version1"
      appear1:required="true" xmlns:appear="http://anything">
  <model>
    <listOfCompartments>
      <compartment id="c" constant="true" units="litre"/>
    </listOfCompartments>
    <appear:listOfShapes>
      <appear:shape appear:id="circle"/>
    </appear:listOfShapes>
  </model>
</sbml>

Tagging @daemontus for bringing this to our attention.

@skeating skeating self-assigned this Aug 18, 2024
@skeating
Copy link
Member

Error 99107 is correct because the namespace "appear1" mimics l3v1 package namespace and indeed has the required so printing the warning that this package cannot be interpreted is correct.

Error 10102 should not be reported as you accurately say it is not attempting to be in the sbml namespace

@skeating skeating linked a pull request Aug 26, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants