Skip to content

Commit 5f09983

Browse files
authored
Merge branch 'develop' into dependabot/github_actions/actions/checkout-5
2 parents a36b578 + 7b09924 commit 5f09983

File tree

2 files changed

+19
-26
lines changed

2 files changed

+19
-26
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
java: 11
3535
distribution: temurin
3636
jobtype: 2
37-
- os: windows-latest
37+
- os: windows-2025
3838
java: 8
3939
distribution: zulu
4040
jobtype: 3

io/src/test/scala/sbt/internal/io/SourceModificationWatchSpec.scala

Lines changed: 18 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -97,21 +97,16 @@ private[sbt] trait EventMonitorSpec { self: AnyFlatSpec & Matchers =>
9797

9898
it should "ignore creation of files that are explicitly ignored" in IO
9999
.withTemporaryDirectory { dir =>
100-
// TODO https://github.com/sbt/io/issues/434
101-
if (scala.util.Properties.isWin) {
102-
pending
103-
} else {
104-
val parentDir = dir / "src" / "watchme"
105-
val created = parentDir / ".hidden.scala"
106-
val notIgnored = parentDir / "foo.scala"
100+
val parentDir = dir / "src" / "watchme"
101+
val created = parentDir / ".hidden.scala"
102+
val notIgnored = parentDir / "foo.scala"
107103

108-
IO.createDirectory(parentDir)
104+
IO.createDirectory(parentDir)
109105

110-
assert(watchTest(parentDir, AllPass, excludes(created.toPath)) {
111-
randomTouch(created)
112-
randomTouch(notIgnored)
113-
})
114-
}
106+
assert(watchTest(parentDir, AllPass, excludes(created.toPath)) {
107+
randomTouch(created)
108+
randomTouch(notIgnored)
109+
})
115110
}
116111

117112
it should "ignore creation of an empty directory" in IO.withTemporaryDirectory { dir =>
@@ -196,20 +191,18 @@ private[sbt] trait EventMonitorSpec { self: AnyFlatSpec & Matchers =>
196191

197192
it should "ignore deletion of files not included in inclusion filter" in IO
198193
.withTemporaryDirectory { dir =>
199-
// TODO https://github.com/sbt/io/issues/434
200194
if (scala.util.Properties.isWin) {
201-
pending
202-
} else {
203-
val parentDir = dir / "src" / "watchme"
204-
val file = parentDir / "inme"
205-
IO.write(file, "foo")
206-
val source = parentDir / "foo.scala"
207-
208-
assert(watchTest(parentDir, AllPass, excludes(file.toPath)) {
209-
IO.delete(file)
210-
randomTouch(source)
211-
})
195+
pending // TODO
212196
}
197+
val parentDir = dir / "src" / "watchme"
198+
val file = parentDir / "inme"
199+
IO.write(file, "foo")
200+
val source = parentDir / "foo.scala"
201+
202+
assert(watchTest(parentDir, AllPass, excludes(file.toPath)) {
203+
IO.delete(file)
204+
randomTouch(source)
205+
})
213206
}
214207

215208
it should "ignore deletion of files explicitly ignored" in IO.withTemporaryDirectory { dir =>

0 commit comments

Comments
 (0)