Skip to content

Commit 8d71f66

Browse files
authored
Merge pull request #445 from eed3si9n/wip/githubactions
Update GitHub Actions
2 parents 765740c + 3b3b155 commit 8d71f66

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,15 @@ jobs:
1010
include:
1111
- os: ubuntu-latest
1212
java: 8
13+
distribution: zulu
1314
jobtype: 1
1415
- os: ubuntu-latest
1516
java: 11
17+
distribution: temurin
1618
jobtype: 1
17-
- os: ubuntu-latest
19+
- os: macos-latest
1820
java: 17
21+
distribution: temurin
1922
jobtype: 1
2023
runs-on: ${{ matrix.os }}
2124
env:
@@ -26,11 +29,13 @@ jobs:
2629
- name: Checkout
2730
uses: actions/checkout@v4
2831
- name: Setup JDK
29-
uses: actions/setup-java@v3
32+
uses: actions/setup-java@v4
3033
with:
31-
distribution: temurin
34+
distribution: "${{ matrix.distribution }}"
3235
java-version: "${{ matrix.java }}"
3336
cache: sbt
37+
- name: Setup sbt
38+
uses: sbt/setup-sbt@v1
3439
- name: Build and test (1)
3540
if: ${{ matrix.jobtype == 1 }}
3641
shell: bash

ivy/src/test/scala/sbt/internal/librarymanagement/ModuleResolversTest.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ object ModuleResolversTest extends BaseIvySpecification {
4343
println(s"NORMAL RESOLUTION TIME $normalResolutionTime")
4444
println(s"FASTER RESOLUTION TIME $fasterResolutionTime")
4545

46-
// Check that faster resolution is at least 1/5 faster than normal resolution
47-
// This is a conservative check just to make sure we don't regress -- speedup is higher
48-
assert(fasterResolutionTime <= (normalResolutionTime * 0.80))
46+
// Check that faster resolution is faster
47+
assert(fasterResolutionTime < normalResolutionTime)
4948
}
5049
}

0 commit comments

Comments
 (0)