Skip to content

Commit 11e724e

Browse files
authored
Merge pull request #85 from gemelen/feature/upgrade-maven
Feature/upgrade maven
2 parents 0f17de6 + 9ebae1b commit 11e724e

File tree

4 files changed

+16
-28
lines changed

4 files changed

+16
-28
lines changed

build.sbt

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
val mvnVersion = "3.8.2"
2-
val mvnResolverVersion = "1.7.2"
1+
val mvnVersion = "3.9.4"
2+
val mvnResolverVersion = "1.9.18"
33
val scala212 = "2.12.19"
44

55
ThisBuild / organization := "com.github.sbt"
@@ -19,11 +19,17 @@ lazy val root = (project in file("."))
1919
.enablePlugins(SbtPlugin)
2020
.settings(nocomma {
2121
name := "sbt-pom-reader"
22+
scalacOptions := Seq(
23+
"-Wconf:any:wv",
24+
"-Xlint:unused",
25+
"-Xlint:deprecation"
26+
)
2227

2328
libraryDependencies ++= Seq(
2429
"org.apache.maven" % "maven-embedder" % mvnVersion
2530
) ++ Seq(
2631
"org.apache.maven.resolver" % "maven-resolver-connector-basic",
32+
"org.apache.maven.resolver" % "maven-resolver-supplier",
2733
"org.apache.maven.resolver" % "maven-resolver-transport-file",
2834
"org.apache.maven.resolver" % "maven-resolver-transport-http",
2935
"org.apache.maven.resolver" % "maven-resolver-transport-wagon"
@@ -39,6 +45,6 @@ lazy val root = (project in file("."))
3945

4046
scriptedLaunchOpts := scriptedLaunchOpts.value ++ Seq("-Dproject.version=" + version.value)
4147
scriptedLaunchOpts ++= Seq("-Dplugin.version=" + version.value)
42-
scriptedBufferLog := false
48+
scriptedBufferLog := true
4349
scriptedSbt := "1.9.9"
4450
})

src/main/scala/sbtpomreader/MavenHelper.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,10 @@ object MavenHelper {
8080
scalaVersion.value
8181
}
8282
},
83-
unmanagedSourceDirectories in Compile ++= {
83+
Compile / unmanagedSourceDirectories ++= {
8484
getAdditionalSourcesFromPlugin(effectivePom.value).filterNot(_.contains("test")).map(x => baseDirectory.value / x)
8585
},
86-
unmanagedSourceDirectories in Test ++= {
86+
Test / unmanagedSourceDirectories ++= {
8787
getAdditionalSourcesFromPlugin(effectivePom.value).filter(_.contains("test")).map(x => baseDirectory.value / x)
8888
},
8989
libraryDependencies ++= fromPom(getDependencies).value,

src/main/scala/sbtpomreader/MavenProjectHelper.scala

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,10 @@
11
package sbtpomreader
22

3-
import sbtpomreader.SbtPomKeys._
4-
53
import sbt._
6-
import sbt.Keys._
74

85
import scala.collection.JavaConverters._
96

10-
import org.apache.maven.model.{
11-
Dependency => PomDependency,
12-
Model => PomModel,
13-
Plugin => PomPlugin,
14-
Repository => PomRepository
15-
}
7+
import org.apache.maven.model.{ Model => PomModel }
168

179
/** This object knows how to load maven reactor projects and turn them into sbt projects. */
1810
object MavenProjectHelper {

src/main/scala/sbtpomreader/package.scala

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,14 @@ import java.io.File
22

33
import org.apache.maven.repository.internal.MavenRepositorySystemUtils
44
import org.eclipse.aether.RepositorySystem
5-
import org.eclipse.aether.connector.basic.BasicRepositoryConnectorFactory
65
import org.eclipse.aether.repository.LocalRepository
7-
import org.eclipse.aether.spi.connector.RepositoryConnectorFactory
8-
import org.eclipse.aether.spi.connector.transport.TransporterFactory
9-
import org.eclipse.aether.transport.file.FileTransporterFactory
10-
import org.eclipse.aether.transport.http.HttpTransporterFactory
11-
import org.eclipse.aether.transport.wagon.WagonTransporterFactory
6+
import org.eclipse.aether.supplier.RepositorySystemSupplier
127

138
/** Helper methods for dealing with starting up Aether. */
149
package object sbtpomreader {
15-
def newRepositorySystemImpl: RepositorySystem = {
16-
val locator = MavenRepositorySystemUtils.newServiceLocator()
17-
locator.addService(classOf[RepositoryConnectorFactory], classOf[BasicRepositoryConnectorFactory])
18-
locator.addService(classOf[TransporterFactory], classOf[FileTransporterFactory])
19-
locator.addService(classOf[TransporterFactory], classOf[HttpTransporterFactory])
20-
locator.addService(classOf[TransporterFactory], classOf[WagonTransporterFactory])
21-
locator.getService(classOf[RepositorySystem])
22-
}
10+
def newRepositorySystemImpl: RepositorySystem =
11+
this.synchronized[RepositorySystem](new RepositorySystemSupplier().get())
12+
2313
def newSessionImpl(system: RepositorySystem, localRepoDir: File) = {
2414
val session = MavenRepositorySystemUtils.newSession()
2515
val localRepo = new LocalRepository(localRepoDir.getAbsolutePath)

0 commit comments

Comments
 (0)