Support for pull diagnostics

[caenrique]

Hi, I was wondering if it is planned at some point to support pull diagnostics?

I'm interested in particular because of the ability to pull for workspace diagnostics, which currently is not possible. This means that errors in files that are not open in the client are not shown and leads to a bad user experience.

For example:

• something is not compiling in file A that was not opened by the editor in this session.
• I am editing another file that imports something from file A.
• Completions do not work properly because compilation didn't work. I cannot see any diagnostics that would give me a clue as to why completions are not working.
• I have to resort to opening the logs or run sbt compile to manually see compilation errors.
• I cannot trust the lack of diagnostics to mean that the project compiles correctly.

If pull diagnostics are not planed to be supported, is there anything that could be done in the client implementation for the editor that would achieve the same result?

I'm using:

• neovim v0.11.0-dev-1804+g2e0a563828
• Metals Server version: 1.5.1

[tgodzik]

Thanks for the question! There are no plan currently about pull diagnostics, but I wonder how it would help in your case? If the error is coming from a file that is not opened currently then whether it's pull or push it will not show, right?

I might be misunderstanding something completely here and I am not opposed to pull diagnostics, we just do not have time currently to work on it.

[caenrique]

Even is I don't have a file opened, the server must know if there are any errors there because the project would not compile right?

Currently only the opened files will get push diagnostics. What I don't know is if the server can gather those errors and make them available as diagnostics (but I am assuming that should be possible) if the client requests them.

Is it not possible for the server to compute all diagnostics of the project when compiling?

[tgodzik]

For sure we can delay publishing diagnostics until the client asks for them. The simplest way is to just cache them and send once requested.
However, I wonder if this indeed help in your case. Wow would you know to open the A file and fix the errors there if the errors were not pushed? When would the client pull the diagnostics for file A if not on opening the file?

Or is the current behaviour that the diagnostics for A are just lost? @ckipp01 Do you have some more background here?