Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where does action clipping happen? #14

Open
51616 opened this issue Jan 17, 2022 · 0 comments
Open

Where does action clipping happen? #14

51616 opened this issue Jan 17, 2022 · 0 comments

Comments

@51616
Copy link

51616 commented Jan 17, 2022

Hey, thank you for such a great addition to multi-agent cooperative environment.

I am playing with the environment and notice that the environment's action space is bounded within [-1,1]. But if the action is outside the range, the environment doesn't throw any error. Instead, it works normally. So I wonder where does the clipping happen?

Another question regarding the FACMAC paper. Did you use any wrapper such as observation/reward normalization or action clipping/rescaling? 'Cause in the original single-agent mode, the implementation usually use normalization and clipping wrapper for Mujoco tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant