Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify various request forms #141

Closed
alishaevn opened this issue Jan 19, 2023 · 4 comments
Closed

verify various request forms #141

alishaevn opened this issue Jan 19, 2023 · 4 comments

Comments

@alishaevn
Copy link
Contributor

alishaevn commented Jan 19, 2023

Story

When we created the request form, it was all based on the "general" dynamic form. As I was viewing the request form for the lean six sigma item, I noticed that the form didn't display as expected. Most likely it's using a different form type with some properties we aren't accounting for. We ought to look at the form for every item on acme prod in the webstore to make sure that we're accounting for multiple scenarios.

BTW -- the javascript manipulation we're doing in the webtore will eventually all be moved to the api or rx app

demo

Image

@alishaevn alishaevn converted this from a draft issue Jan 19, 2023
@alishaevn
Copy link
Contributor Author

alishaevn commented Jan 24, 2023

This ticket is blocked by #151

@alishaevn alishaevn changed the title fix the lean six sigma request form verify various request forms Jan 24, 2023
@summer-cook
Copy link
Contributor

I noticed this is happening to a lot of other forms on prod, not too much of an issue on staging though

this is in the Next Gen Sequencing form

Image

I noticed this in almost every ware's form besides the CRISPR demo one.

@alishaevn
Copy link
Contributor Author

I may need to check in with sherman about the different dynamic form types. but first, I'd like to compare the ui options code in webstore vs the one in the rx-lite app. it may be a view issue and not a schema issue. 🤔

@alishaevn
Copy link
Contributor Author

instead of trying to update the formatting for these various forms in the webstore, we're going to just go forward with working on the api. re: #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants