Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle conditional fields #332

Open
7 tasks
alishaevn opened this issue Dec 1, 2023 · 0 comments · May be fixed by #336
Open
7 tasks

handle conditional fields #332

alishaevn opened this issue Dec 1, 2023 · 0 comments · May be fixed by #336
Assignees

Comments

@alishaevn
Copy link
Contributor

alishaevn commented Dec 1, 2023

Story

sometimes, an input on a form should only show based on the value of another input.
an example can be found at https://beachsidebiotech.scientist.com/wares/peptide-synthesis4/quote_groups/new. Clicking "yes" or "no" to the question "Have you already identified supplier(s) for this service?", shows other questions, based on each answer.

currently, all questions show on the request form, with no conditional behavior being accounted for. handling conditional functionality provides for a better experience for the user, and allows cleaner and easier forms for professional services and consigners.

related thread: https://assaydepot.slack.com/archives/C03FZDALABG/p1716585510373949

Acceptance Criteria

  • dependencies (conditionals)
  • optionLabels not respected for enums
  • rightLabel not respected for booleans
  • noneLabel not respected for select type
  • hidden option attribute not respected
  • helper text has no visual difference compared to field values (on app, it displays an info glyphicon with greyed out text)
  • default values are not being respected (e.g. arrays)

Screenshots / Video

note that "look" below refers to the presence/absence of questions. not styling

how it should look

Image

how it's looking

Image

Testing Instructions and Sample Files

Notes

  • check for properties with an "enum" property
  • not all conditional fields are based on an array
  • sometimes clicking a certain option (like "other") is what renders the conditional field(s)
  • sometimes, clicking any option on the question, renders the conditional field(s)

Resources

@alishaevn alishaevn self-assigned this Dec 2, 2023
@alishaevn alishaevn linked a pull request Dec 7, 2023 that will close this issue
@alishaevn alishaevn removed this from webstore Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant