Skip to content

Commit 51c37ad

Browse files
Fix CI: missing Qt Setup in release test (#1081)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 64c2814 commit 51c37ad

File tree

6 files changed

+39
-15
lines changed

6 files changed

+39
-15
lines changed

.github/workflows/coverage.yml

+21-8
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,31 @@ name: Coverage
22

33
on:
44
pull_request:
5-
paths-ignore:
6-
- 'doc/**'
7-
- '.ci/**'
8-
- '*.rst'
5+
paths:
6+
- src
7+
- extern
8+
- tests
9+
- pyproject.toml
10+
- noxfile.py
11+
- CMakeLists.txt
12+
- .github/workflows/coverage.yml
913
push:
1014
branches:
1115
- main
1216
- develop
1317
- beta/*
14-
paths-ignore:
15-
- 'doc/**'
16-
- '.ci/**'
17-
- '*.rst'
18+
paths:
19+
- src
20+
- extern
21+
- tests
22+
- pyproject.toml
23+
- noxfile.py
24+
- CMakeLists.txt
25+
- .github/workflows/coverage.yml
26+
27+
concurrency:
28+
group: ${{ github.workflow }}-${{ github.head_ref }}
29+
cancel-in-progress: true
1830

1931
jobs:
2032
coverage:
@@ -32,6 +44,7 @@ jobs:
3244
- uses: actions/setup-python@v5
3345
with:
3446
python-version: "3.12"
47+
# without this, the Qt tests abort because a lib is missing
3548
- uses: tlambert03/setup-qt-libs@v1
3649
- uses: astral-sh/setup-uv@v4
3750
- run: uv pip install --system nox

.github/workflows/release.yml

+6
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ on:
99
paths:
1010
- .github/workflows/release.yml
1111

12+
concurrency:
13+
group: ${{ github.workflow }}-${{ github.head_ref }}
14+
cancel-in-progress: true
15+
1216
env:
1317
# Latest Jupyter requires this to acknowledge deprecation
1418
JUPYTER_PLATFORM_DIRS: 1
@@ -81,6 +85,8 @@ jobs:
8185
- uses: actions/checkout@v4
8286
with:
8387
submodules: true
88+
# without this, the Qt tests abort because a lib is missing
89+
- uses: tlambert03/setup-qt-libs@v1
8490

8591
- run: pipx run build --sdist
8692

.github/workflows/test.yml

+8-5
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,13 @@ name: Test
22

33
on:
44
pull_request:
5-
paths-ignore:
6-
- 'doc/**'
7-
- '.ci/**'
8-
- '*.rst'
5+
paths:
6+
- src
7+
- extern
8+
- tests
9+
- pyproject.toml
10+
- CMakeLists.txt
11+
- .github/workflows/test.yml
912

1013
env:
1114
CMAKE_ARGS: -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
@@ -50,4 +53,4 @@ jobs:
5053
# pip install .[test] is not used here to test minimum (faster)
5154
# cov workflow runs all tests
5255
- run: uv pip install --system . pytest pytest-xdist ${{ matrix.installs }}
53-
- run: python -m pytest -n 3
56+
- run: pytest -n 3

.gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -66,3 +66,5 @@ doc/index.rst
6666
testcase
6767

6868
*venv*
69+
70+
uv.lock

noxfile.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Pass extra arguments to pytest after --
55
"""
66

7-
import nox
7+
import nox # type:ignore
88
import sys
99

1010
sys.path.append(".")

version.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
try:
66
import tomllib as toml
77
except ModuleNotFoundError:
8-
import tomli as toml
8+
import tomli as toml # type: ignore
99

1010
with open(PurePath(__file__).parent / "pyproject.toml", "rb") as f:
1111
version = toml.load(f)["project"]["version"]

0 commit comments

Comments
 (0)