Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router: investigate performance of SCMP parsing in router #4547

Open
matzf opened this issue Jun 10, 2024 · 0 comments
Open

router: investigate performance of SCMP parsing in router #4547

matzf opened this issue Jun 10, 2024 · 0 comments
Labels
workitem Something needs doing

Comments

@matzf
Copy link
Contributor

matzf commented Jun 10, 2024

Follow up on #4344

Since #4344, delivering an SCMP error message to an end host in the destination AS (the destination of the SCMP message, that is, i.e. the source AS of the offending packet) requires the router to parse the SCMP message. It inspects the quoted offending packet in the SCMP error message to determine the port from which the offending packet was sent. This is then used as the destination port for the SCMP error message.

The implementation of this procedure in the router is somewhat simplistic. It uses the gopacket.NewPacket API, which eagerly parses the full structure and allocates various internal helper objects. Instead, the router should likely only perform minimal, using DecodeFromBytes with re-usable layer objects.
Investigate how big the impact is of this eager parsing and temporary objects.

@matzf matzf added the workitem Something needs doing label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workitem Something needs doing
Projects
None yet
Development

No branches or pull requests

1 participant